fix(ios): present share sheet from topmost controller#41
Open
fdddf wants to merge 1 commit into
Open
Conversation
AldenClark
added a commit
to AldenClark/textual
that referenced
this pull request
Apr 21, 2026
Owner
|
Sorry for the late review, and thanks for looking into this. The direction makes sense, but I’d rather not merge it as-is. The presenter lookup still has edge cases: it can miss an already-presented modal, and the fallback can pick a window from another scene. I’d prefer keeping this scoped to the view’s own window scene and checking presented view controllers first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.