Fix negative CTC loss for confident alignments in float32 - #1772
Open
rajasekharporeddy wants to merge 1 commit into
Open
Fix negative CTC loss for confident alignments in float32#1772rajasekharporeddy wants to merge 1 commit into
rajasekharporeddy wants to merge 1 commit into
Conversation
rajasekharporeddy
force-pushed
the
ctc_loss
branch
from
September 7, 2026 15:03
1f55d64 to
9111f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1771
Summary
In$< 0$ ) for highly confident alignments due to precision limits in
float32arithmetic,optax.ctc_lossandoptax.ctc_loss_with_forward_probscan round below zero (log_softmaxandlogaddexp. This PR enforces the mathematical bounds by clamping forward log-probabilities from above at0.0and per-sequence loss from below at0.0.Changes
optax.losses.ctc_loss_with_forward_probs:logalpha_phiandlogalpha_emitfrom above at0.0usingjnp.minimum(..., 0.0).per_seq_lossfrom below at0.0usingjnp.maximum(per_seq_loss, 0.0).optax/losses/_classification_test.py:test_confident_alignment_nonnegativeinCTCTestto verify that bothctc_lossandctc_loss_with_forward_probsmaintain non-negative loss and non-positive log-probabilities under confident alignments.