fix: refresh expired OAuth tokens for older chat sessions#5578
Open
ShivamRIG wants to merge 1 commit intogoogle:mainfrom
Open
fix: refresh expired OAuth tokens for older chat sessions#5578ShivamRIG wants to merge 1 commit intogoogle:mainfrom
ShivamRIG wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
Testing PlanAdded 3 unit tests in
All 3 tests pass: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5556
Problem:
Old chat sessions retained expired access tokens in session.state.
Tokens were never refreshed, causing tools to fail in older chats.
Reloading the page did not help as the session is server-side.
Fix:
Added _refresh_token_if_expired() method to A2aAgentExecutor.
Called after _prepare_session() in _handle_request(), before
the runner executes. Checks expiry, refreshes using refresh_token,
and updates session state with new access_token and expires_at.
Tests:
Added 3 unit tests covering: