Repository navigation
test(agent_transfer): add regression tests for non-LlmAgent peer transfers - #6210
Closed
AliMuhammadAslam wants to merge 2 commits into
Closed
AliMuhammadAslam wants to merge 2 commits into
AliMuhammadAslam wants to merge 2 commits into
Conversation
…sfers Regression tests for google#5863. Before the hasattr guard was added to _get_transfer_targets, placing any agent without a 'mode' attribute (LoopAgent, SequentialAgent, ParallelAgent) alongside an LlmAgent in a parent's sub_agents raised: AttributeError: '<AgentType>' object has no attribute 'mode' Five tests are added: - LoopAgent as a peer agent does not raise - LoopAgent as a sub-agent does not raise - SequentialAgent as a peer agent does not raise - ParallelAgent as a peer agent does not raise - LlmAgent with mode='single_turn' is correctly excluded from targets
rohityan
added
the
core
rohityan
added
the
needs review
Collaborator
|
Hi @AliMuhammadAslam , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Collaborator
|
Hi @xuanyang15 , can you please review this. |
Contributor
Author
|
Hi @xuanyang15, just checking in on this — it's been a couple weeks since rohityan flagged it for your review. It's a small, test-only PR (the regression tests requested when #5910 was closed), and all checks are passing. Let me know if anything needs changing. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
Merge #6210 --- Adds regression tests for the `AttributeError` that occurred when `_get_transfer_targets` iterated over peer agents without a `mode` attribute (e.g. `LoopAgent`, `SequentialAgent`, `ParallelAgent`). The core fix — the `hasattr` guard in `_get_transfer_targets` — is already in `main`. These tests ensure the behaviour does not regress. As noted in #5910, the tests were not yet in `main`, so this is a test-only PR with no production code changes. **Five tests added to `test_get_transfer_targets.py`:** - `LoopAgent` as a peer agent does not raise `AttributeError` - `LoopAgent` as a sub-agent does not raise `AttributeError` - `SequentialAgent` as a peer agent does not raise `AttributeError` - `ParallelAgent` as a peer agent does not raise `AttributeError` - `LlmAgent` with `mode='single_turn'` is correctly excluded from transfer targets (verifies the filtering logic, not just the guard) All five use `MockModel` and real ADK agent objects — no external dependencies or mocking of internals. Co-authored-by: Xuan Yang <xygoogle@google.com> COPYBARA_INTEGRATE_REVIEW=#6210 from AliMuhammadAslam:test/loop-agent-peer-transfer-regression 7d6ada7 PiperOrigin-RevId: 948623403
Collaborator
|
Thank you @AliMuhammadAslam for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 58a14e1. Closing this PR as the changes are now in the main branch. |
FrigaZzz
pushed a commit
to FrigaZzz/adk-python
that referenced
this pull request
Aug 11, 2026
Merge google#6210 --- Adds regression tests for the `AttributeError` that occurred when `_get_transfer_targets` iterated over peer agents without a `mode` attribute (e.g. `LoopAgent`, `SequentialAgent`, `ParallelAgent`). The core fix — the `hasattr` guard in `_get_transfer_targets` — is already in `main`. These tests ensure the behaviour does not regress. As noted in google#5910, the tests were not yet in `main`, so this is a test-only PR with no production code changes. **Five tests added to `test_get_transfer_targets.py`:** - `LoopAgent` as a peer agent does not raise `AttributeError` - `LoopAgent` as a sub-agent does not raise `AttributeError` - `SequentialAgent` as a peer agent does not raise `AttributeError` - `ParallelAgent` as a peer agent does not raise `AttributeError` - `LlmAgent` with `mode='single_turn'` is correctly excluded from transfer targets (verifies the filtering logic, not just the guard) All five use `MockModel` and real ADK agent objects — no external dependencies or mocking of internals. Co-authored-by: Xuan Yang <xygoogle@google.com> COPYBARA_INTEGRATE_REVIEW=google#6210 from AliMuhammadAslam:test/loop-agent-peer-transfer-regression 7d6ada7 PiperOrigin-RevId: 948623403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5863
Adds regression tests for the
AttributeErrorthat occurred when_get_transfer_targetsiterated over peer agents without amodeattribute (e.g.LoopAgent,SequentialAgent,ParallelAgent).The core fix — the
hasattrguard in_get_transfer_targets— is already inmain. These tests ensure the behaviour does not regress. As noted in #5910, the tests were not yet inmain, so this is a test-only PR with no production code changes.Five tests added to
test_get_transfer_targets.py:LoopAgentas a peer agent does not raiseAttributeErrorLoopAgentas a sub-agent does not raiseAttributeErrorSequentialAgentas a peer agent does not raiseAttributeErrorParallelAgentas a peer agent does not raiseAttributeErrorLlmAgentwithmode='single_turn'is correctly excluded from transfer targets (verifies the filtering logic, not just the guard)All five use
MockModeland real ADK agent objects — no external dependencies or mocking of internals.