Refactor legacy Dagger tests to prefer assertThrows to try/fail.#5158
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 22, 2026
Merged
Refactor legacy Dagger tests to prefer assertThrows to try/fail.#5158copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
This change updates legacy tests in the Dagger project to use
`org.junit.Assert.assertThrows` instead of the `try { ... fail(); } catch (...) { ... }`
pattern.
RELNOTES=Refactor legacy tests to use assertThrows instead of try/fail.
PiperOrigin-RevId: 903943435
copybara-service
Bot
force-pushed
the
test_903498994
branch
from
1aa0955 to
f15088d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor legacy Dagger tests to prefer assertThrows to try/fail.
This change updates legacy tests in the Dagger project to use
org.junit.Assert.assertThrowsinstead of thetry { ... fail(); } catch (...) { ... }pattern.
RELNOTES=Refactor legacy tests to use assertThrows instead of try/fail.