Repository navigation
Conversation
1 task
Collaborator
Author
|
Closing in favor of a single chained PR stacked on #459. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Key Changes
Updates the
/egm-liteskill implementation (skills/egm-lite/), test suite, and Starlight documentation (docs/site/skills/egm-lite.md) in #438 (implementing the updated design in #445 / #419) so pre-implementation Goldfish specification review is automatic, post-implementation Goldfish diff re-review is optional, and Goldfish is reserved strictly for isolated fresh-context subagents across a 6-phase state machine:skills/egm-lite/SKILL.md):The Critique Pause) toThe Elephant (Critic)(in-session deep-context critique) and flattens checklist generation and spec review into Section 2 (Execution Checklist— Elephant Planner) chaining automatically in the same turn into Section 3 (Automatic Specification Review— Goldfish Specification Reviewer via Subagent) (falling back to human approval without simulating a same-context review if the host exposes no subagent tool).State Transitions & Command Aliasesand[State Advisory]guards preventing prematureexecor diffreviewbefore checklist generation and specification review.Exec Protocol) before the first task edit, finishes cleanly on passing tests while presenting post-implementation diff re-review (review/goldfish) as optional, and updates Section 5 (Optional Adversarial Diff Re-Review) to collect committed task changes, unstaged edits, and untracked files against the recorded baseline while keeping unrelated pre-existing edits separate.Unified Post-Review Resolution Gate) to discriminate pre-implementation spec reviews (stampingVerified [✅ LGTM]and gating onexec/ Proceed without premature task closure) from post-implementation diff re-reviews.skills/egm-lite/TEST.md,skills/egm-lite/test_scenarios.yaml,docs/site/skills/egm-lite.md):[State Advisory]guards, spec LGTM vs. findings triage, optional post-implementation re-review, and baseline-aware untracked/committed change collection.Contribution Type
Track: Feature / Architectural Change -- Stage 2: Implementation PR
Verification
pytest tests/unit/test_skill_load_limits.py tests/unit/test_frontmatter.py tests/unit/test_link_integrity.py tests/unit/test_markdown_tables.py tests/unit/test_packaging.py tests/unit/test_harnesses.py tests/unit/test_opencode_adapter.py tests/unit/test_scenario_coverage.py— passed (skills/egm-lite/SKILL.mdis 20,186 bytes total, within Antigravity's 24,000-byte skill body limit).skills/egm-lite/test_scenarios.yaml.EGM_CLAUDE_LIVE,EGM_CODEX_LIVE) —not runlocally (covered by GitHub Actions CI for offline site/workflow checks).Human Accountability Affirmation