Repository navigation
Conversation
1 task done
eewing314
force-pushed
the
feat/egm-lite-automatic-spec-review
branch
from
November 17, 2026 03:48
b9ffc94 to
37b9454
Compare
eewing314
force-pushed
the
feat/egm-lite-automatic-spec-review
branch
from
November 17, 2026 16:28
37b9454 to
12e4a4d
Compare
Collaborator
Author
|
Closing for now—#459 covers the persona, baseline, and skippable Goldfish review updates, and we will revisit default recommendation thresholds after testing egm-lite on local tasks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Key Changes
Makes a focused update stacked on #459 so
/egm-litealways recommends running the fresh-context Goldfish specification review (goldfish/review) afteregm_lite_checklist.mdis created (rather than framing it as "optional" or gating the recommendation on multi-file complexity), while still allowing developers to skip straight toexec/ Proceed:docs/designs/lite.md,skills/egm-lite/SKILL.md,docs/site/skills/egm-lite.md):> **BLUF:**recommendation to rungoldfishorreviewonegm_lite_checklist.mdbefore implementation, removing "optional" / "opt-in" wording on the checklist spec review while preservingexec/ Proceed for users who choose to skip.docs/designs/lite.md,skills/egm-lite/SKILL.md):Critique Pause) to Elephant (Critic) (in-session deep-context critique) so Goldfish refers strictly to isolated, fresh-context subagent reviews (Phases 2B and 4).skills/egm-lite/TEST.md,skills/egm-lite/test_scenarios.yaml):TEST.md,gate_halt_after_checklist,readme_grounding_and_inline_checklist_comments, andspec_review_recommended_by_defaultto assert that Section 1 usesElephant (Critic)and Section 2A always recommendsgoldfish/reviewby default (even on routine single-file changes) without labeling spec review "optional", while keepingexec/ Proceed available to skip.Stacked on #459.
Refs #460
Refs #461
Contribution Type
Track: Feature / Architectural Change -- Stage 2: Implementation PR
Verification
pytest tests/unit/test_skill_load_limits.py tests/unit/test_frontmatter.py tests/unit/test_link_integrity.py tests/unit/test_markdown_tables.py tests/unit/test_scenario_coverage.py— 14 passed (skills/egm-lite/SKILL.mdbody is 21,764 UTF-8 bytes, within the 24,000-byte limit).skills/egm-lite/test_scenarios.yaml.EGM_CLAUDE_LIVE,EGM_CODEX_LIVE) —not runlocally (offline site/workflow checks run in GitHub Actions CI).Human Accountability Affirmation