Skip to content

Recommend pre-implementation checklist spec review by default in egm-lite - #463

Closed
eewing314 wants to merge 1 commit into
google:feat/egm-lite-adaptive-gatingfrom
eewing314:feat/egm-lite-automatic-spec-review
Closed

eewing314 wants to merge 1 commit into
google:feat/egm-lite-adaptive-gatingfrom
eewing314:feat/egm-lite-automatic-spec-review

Conversation

@eewing314

@eewing314 eewing314 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary of Key Changes

Makes a focused update stacked on #459 so /egm-lite always recommends running the fresh-context Goldfish specification review (goldfish / review) after egm_lite_checklist.md is created (rather than framing it as "optional" or gating the recommendation on multi-file complexity), while still allowing developers to skip straight to exec / Proceed:

  • Recommended Pre-Implementation Spec Review (docs/designs/lite.md, skills/egm-lite/SKILL.md, docs/site/skills/egm-lite.md):
    • Replaces the complexity-threshold split in Section 2A / Phase 2A with a default > **BLUF:** recommendation to run goldfish or review on egm_lite_checklist.md before implementation, removing "optional" / "opt-in" wording on the checklist spec review while preserving exec / Proceed for users who choose to skip.
  • Elephant vs. Goldfish Persona Alignment (docs/designs/lite.md, skills/egm-lite/SKILL.md):
    • Assigns Phase 1 (Critique Pause) to Elephant (Critic) (in-session deep-context critique) so Goldfish refers strictly to isolated, fresh-context subagent reviews (Phases 2B and 4).
  • Verification & Scenario Coverage (skills/egm-lite/TEST.md, skills/egm-lite/test_scenarios.yaml):
    • Updates TEST.md, gate_halt_after_checklist, readme_grounding_and_inline_checklist_comments, and spec_review_recommended_by_default to assert that Section 1 uses Elephant (Critic) and Section 2A always recommends goldfish / review by default (even on routine single-file changes) without labeling spec review "optional", while keeping exec / Proceed available to skip.

Stacked on #459.

Refs #460
Refs #461

Contribution Type

Track: Feature / Architectural Change -- Stage 2: Implementation PR

Verification

  • pytest tests/unit/test_skill_load_limits.py tests/unit/test_frontmatter.py tests/unit/test_link_integrity.py tests/unit/test_markdown_tables.py tests/unit/test_scenario_coverage.py — 14 passed (skills/egm-lite/SKILL.md body is 21,764 UTF-8 bytes, within the 24,000-byte limit).
  • Validated all 23 scenario regex patterns in skills/egm-lite/test_scenarios.yaml.
  • Node-dependent workflow/site checks and live model behavioral probes (EGM_CLAUDE_LIVE, EGM_CODEX_LIVE) — not run locally (offline site/workflow checks run in GitHub Actions CI).

Human Accountability Affirmation

@eewing314 eewing314 added docs Improvements or additions to documentation site Changes to the project website labels Nov 17, 2026
@n3wth n3wth mentioned this pull request Nov 17, 2026
1 task done
@eewing314
eewing314 force-pushed the feat/egm-lite-automatic-spec-review branch from b9ffc94 to 37b9454 Compare November 17, 2026 03:48
@eewing314 eewing314 changed the title Make pre-implementation spec review automatic in egm-lite Recommend pre-implementation checklist spec review by default in egm-lite Nov 17, 2026
@eewing314
eewing314 force-pushed the feat/egm-lite-automatic-spec-review branch from 37b9454 to 12e4a4d Compare November 17, 2026 16:28
@eewing314

Copy link
Copy Markdown
Collaborator Author

Closing for now—#459 covers the persona, baseline, and skippable Goldfish review updates, and we will revisit default recommendation thresholds after testing egm-lite on local tasks.

@eewing314 eewing314 closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation site Changes to the project website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant