Skip to content

Add offline Cursor checks and live test guide - #473

Draft
sahil1115 wants to merge 4 commits into
google:mainfrom
sahil1115:cursor-adapter-verification
Draft

sahil1115 wants to merge 4 commits into
google:mainfrom
sahil1115:cursor-adapter-verification

Conversation

@sahil1115

@sahil1115 sahil1115 commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary of Key Changes

Extends the merged experimental Cursor adapter (design #148, implementation #164) toward the Cursor scope of #145. It adds offline verification and a live runbook. It does not claim support. Installation, workflow, and isolation remain unverified until the live runbook is run. Cursor stays out of the supported-host table. This PR leaves #145 open, and the Grok Bot assessment remains separate.

Key changes:

  • Rule (.cursor-plugin/rules/egm.mdc): egm-lite (added in feat(skills): implement EGM Lite rapid engineering protocol (Stage 2) #438, after feat(cursor): add experimental local Agent support #164) dispatches an ad-hoc Goldfish reviewer with no registered read-only Cursor type. A generic child is not read-only, so the rule routes egm-lite Goldfish reviews to that skill's existing stop path. Every missing-delegation stop now states what is missing, how to remedy it, and which stages and reports were completed and verified before the stop.
  • Offline checks (tests/unit/test_cursor.py):
    • Expected skills and reviewers are derived from skills/ and agents/ rather than fixed lists. A cross-check against the Claude adapters' Agent tool keeps the orchestrator exclusion honest.
    • Manifest path containment checks: relative paths, no .., nothing outside the plugin.
    • A zero-duplication check: an inventory of .cursor-plugin/, plus SHA-256 and 10-word overlap against skills/, agents/, and resources/.
    • A static write-probe harness with negative fixtures.
    • A native negative control showing which read-only field the pinned loader honors.
    • Guards against drifting counts and unverified gates in the guide.
  • Read evidence (tests/integration/cursor_child_reads.py): --absent scans every cell of the closed child SQLite snapshot for a parent-only canary. It checks UTF-8, UTF-16, base64, gzip, and zlib forms and never echoes the marker. Compression it cannot decode is reported as inconclusive (exit 3), never as a pass.
  • Docs (docs/cursor.md): the placement decision and rationale, read-only field evidence per ingestion surface, the recorded probe result, known limitations, a live runbook (installation, isolation canary with per-channel probes, read evidence, write denial, completion records, end to end) that flags every step with model usage, and the evidence ledger. The guide's drifting counts are removed; it said seven skills while eight exist.
  • docs/harnesses.md: one experimental, unverified Cursor note under Support Status. The install table is unchanged.

Shared skills/, agents/, and resources/ are unchanged. The Hermes, OpenClaw, and Delta adapters named in #145 are not in the tree: #119 is a requirements design only, so there are no suites for them to regress.

Contribution Type

Track: Feature / Architectural Change -- Stage 2: Implementation PR

Uses Refs #145, not Closes, because the issue's live gates stay open. The design is #148 (merged).

Verification

Host and version: Cursor CLI 2026.10.01-e373342, inspected and pinned. No model or Cursor agent session ran.

Check Result
Default suite, Linux x86_64, fresh clone of f86e0b4 417 passed, 4 skipped (opt-in native probes), 0 failed
test_cursor 28 passed, 3 skipped (native probes)
test_cursor_child_reads 24 passed
test_copilot_adapter 12 passed, 1 skipped (opt-in native)
test_opencode_adapter / test_opencode_trace_verifier 16 passed / 27 passed
test_windsurf 1 passed
test_claude_traces / test_codex_traces 32 passed / 12 passed
test_harnesses / test_packaging / test_releases 26 / 32 / 19 passed
Pinned native loader probe, linux/arm64 (emulated), checkout of f86e0b4 4 passed. Archive and bundle SHA-256 match the pins
Native negative control readonly: true alone registers permissionMode: default; permissionMode: readonly alone registers readonly
ruff check tests/ Passed

On a Windows checkout, 16 existing OpenCode, packaging, and PR-triage tests fail with WinError 1314 (no symlink privilege). This is unrelated to this change and also happens on main. The Linux results above use a clean clone.

Harness evidence:

  • Installation: not run (the live runbook step 1 is pending).
  • egm-brainstorm: not run.
  • egm-draft: not run.
  • egm-review: not run.
  • Isolation canary, read evidence, read-only write denial, and completion records: not run.

Human Accountability Affirmation

Sahil added 4 commits November 18, 2026 16:17
Route egm-lite Goldfish reviews to that skill's stop path instead of a
generic child, which is not read-only. Every missing-delegation stop now
states what is missing, how to remedy it, and which stages and reports
were completed and verified before the stop.

Refs google#145
Add --absent to the read-evidence utility. It searches every table and
cell of the closed SQLite snapshot in UTF-8, UTF-16, base64, gzip, and
zlib forms and never echoes the marker. Compression it cannot decode is
reported as inconclusive (exit 3), never as a pass.

Refs google#145
Record the manifest placement decision, read-only field evidence per
ingestion surface, the pinned loader probe result and negative control,
known limitations, a step-by-step live runbook that flags every step
with model usage, and the per-gate ledger. All live gates remain
unverified, and Cursor stays out of the supported-host table.

Remove drifting skill and reviewer counts from the guide, and add an
experimental, unverified Cursor note to the harness support status.

Refs google#145
Derive expected skills and reviewers from skills/ and agents/ instead of
fixed lists. Add manifest path containment, a structural and 10-word
overlap zero-duplication check, a static write-probe harness with
negative fixtures, a native negative control showing which read-only
field the pinned loader honors, and checks that keep the guide free of
drifting counts and its gates unverified.

Refs google#145
@google-cla

google-cla Bot commented Nov 18, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@n3wth n3wth changed the title Add offline checks and a live runbook for the Cursor adapter Add offline checks and a live runbook for Cursor adapter Nov 18, 2026
@n3wth n3wth changed the title Add offline checks and a live runbook for Cursor adapter Add offline Cursor checks and live test guide Nov 18, 2026
@sahil1115
sahil1115 marked this pull request as draft November 18, 2026 11:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant