Improve runtime error when indexing a non-indexable value#883
Open
ricardbejarano wants to merge 1 commit into
Open
Improve runtime error when indexing a non-indexable value#883ricardbejarano wants to merge 1 commit into
ricardbejarano wants to merge 1 commit into
Conversation
The error for indexing a non-indexable value exposed the internal Go type name, e.g. `RUNTIME ERROR: Value non indexable: *jsonnet.valueNull`. Use the jsonnet type name instead and explain which types can be indexed, e.g. `Could not index a value of type "null" (only objects, arrays and strings can be indexed)`. Fixes google#258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Indexing a non-indexable value produced an error that leaked the internal Go type name:
This is confusing for users, who have no notion of
*jsonnet.valueNull. The message now uses the jsonnet type name and explains which types can be indexed:Changes
interpreter.go: build the error fromtargetValue.getType().nameinstead ofreflect.TypeOf, matching how other runtime type errors are reported in this file.jsonnet_test.go: add a test covering null, number, boolean and function targets, asserting the message mentions the jsonnet type and does not leak internal Go type names.Fixes #258