Repository navigation
nvproxy: Serve /proc/driver/nvidia/version from the host - #17696
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
nvproxy now serves the host's /proc/driver/nvidia/version unchanged. runsc reads it where it reads params, before the sandbox enters its chroot, and a host without the file still gets a sandbox without one. Linux has this file whenever the NVIDIA driver is loaded, and libnvidia-container copies it into runc containers, but nvproxy sandboxes have only params. NVIDIA's streaming SDK, which Omniverse Kit and Isaac Sim use for WebRTC livestreaming, reads the version file to pick its NVENC API version. Without it the SDK assumes driver 410.96, picks NVENC API 8, and every session fails with NVST_DISCONN_SERVER_VIDEO_ENCODER_INIT_FAILED. Tested: nvconf and nvproxy unit tests on master. The same change on a release branch, on a T4 with driver 610.57.04, served the host's file and let Isaac Sim 6.2's WebRTC livestream stream 1080p60 to Chrome, which fails with the encoder init error without it. The new GPU test, TestProcDriverNvidiaVersion in test/gpu:procfs_test, has not run on a GPU host yet. Auto-fixed-by: [🤖] @EtiennePerot FUTURE_COPYBARA_INTEGRATE_REVIEW=#17497 from edaniels:nvproxy-driver-version 0c0975a PiperOrigin-RevId: 1022654275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvproxy: Serve /proc/driver/nvidia/version from the host
nvproxy now serves the host's /proc/driver/nvidia/version unchanged. runsc reads it where it reads params, before the sandbox enters its chroot, and a host without the file still gets a sandbox without one. Linux has this file whenever the NVIDIA driver is loaded, and libnvidia-container copies it into runc containers, but nvproxy sandboxes have only params. NVIDIA's streaming SDK, which Omniverse Kit and Isaac Sim use for WebRTC livestreaming, reads the version file to pick its NVENC API version. Without it the SDK assumes driver 410.96, picks NVENC API 8, and every session fails with NVST_DISCONN_SERVER_VIDEO_ENCODER_INIT_FAILED.
Tested: nvconf and nvproxy unit tests on master. The same change on a release branch, on a T4 with driver 610.57.04, served the host's file and let Isaac Sim 6.2's WebRTC livestream stream 1080p60 to Chrome, which fails with the encoder init error without it. The new GPU test, TestProcDriverNvidiaVersion in test/gpu:procfs_test, has not run on a GPU host yet.
Auto-fixed-by: [🤖] @EtiennePerot
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17497 from edaniels:nvproxy-driver-version 0c0975a