Preserve setup error records when failure handling aborts - #1030
Open
rksharma-owg wants to merge 1 commit into
Open
Preserve setup error records when failure handling aborts#1030rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
on_failraisesTestAbortAllafter asetup_classfailure, the setup error is missing fromtest_summary.yaml. Expectation failures can also escape before the class error is added to the results.Finalize and persist the setup record in
finallyblocks around the failure callback, so abort propagation still occurs after recording the original setup failure. This covers both raised exceptions and recorded expectation failures without changing normal callback ordering.Validation:
tox: 825 passed, 2 skipped. The run emitted warnings, including missing localadbduring snippet cleanup.pyink --check .: passed for all 106 files.git diff --check: passed.Closes #1029.
Prepared with AI assistance; the reproduction and tests were executed locally.