Forbid subordinate host changes when superord domain is locked#3171
Merged
Conversation
This is not explicitly called out that I could find in the RFCs, however it is very clear from the RFCs that hosts are subordinate to their domains and it stands to reason that updates to a subordinate host are updates to the superordinate domain. Section 1.1 of RFC 5732 specifies: ``` host name "ns1.example.com" has a subordinate relationship to domain name "example.com". EPP actions (such as object transfers) that do not preserve this relationship MUST be explicitly disallowed. ``` Allowing host updates (e.g. renames) opens up situations where this relationship could be severed. We add analogous prohibitions on deletion and creation of subordinate hosts as well. b/534930957
Collaborator
Author
|
note: this PR explicitly does not forbid host updates where the superordinate domain has CLIENT_UPDATE_PROHIBITED set. This is for two reasons.
|
weiminyu
approved these changes
Jul 24, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not explicitly called out that I could find in the RFCs, however it is very clear from the RFCs that hosts are subordinate to their domains and it stands to reason that updates to a subordinate host are updates to the superordinate domain.
Section 1.1 of RFC 5732 specifies:
Allowing host updates (e.g. renames) opens up situations where this relationship could be severed. We add analogous prohibitions on deletion and creation of subordinate hosts as well.
b/534930957
This change is