chore: adding linter to google-cloud-node monorepo (1/5)#8029
Open
shivanee-p wants to merge 5 commits intomainfrom
Open
chore: adding linter to google-cloud-node monorepo (1/5)#8029shivanee-p wants to merge 5 commits intomainfrom
shivanee-p wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first of a series of PRs to migrate packages to standard ESLint and consolidate configurations at the repository root, addressing issue #4580 to prepare for the Librarian migration.
Trying to accomplish moving over the entire repo in 1 PR led to memory issues during analysis, so we are rolling this out in 5 batches. This PR enables and verifies standard ESLint for the first 20 packages.
Changes:
.eslintrc.cjsand.eslintignoreand deleted all package-level.eslintrc.jsonand.eslintignorefiles across the repository.packages/gapic-node-processingpackages/google-ads-admanagerpackages/google-ads-datamanagerpackages/google-ai-generativelanguagepackages/google-analytics-adminpackages/google-analytics-datapackages/google-api-apikeyspackages/google-api-cloudquotaspackages/google-api-servicecontrolpackages/google-api-servicemanagementpackages/google-api-serviceusagepackages/google-appenginepackages/google-apps-events-subscriptionspackages/google-apps-meetpackages/google-area120-tablespackages/google-chatpackages/google-cloud-accessapprovalpackages/google-cloud-advisorynotificationspackages/google-cloud-aiplatformpackages/google-cloud-alloydb/* eslint-disable @typescript-eslint/no-explicit-any */comments to baseline historical violations of theno-explicit-anyrule in these packages.tsconfig.jsonin these 20 packages to correctly extend the rootgtsconfiguration.Verification Results:
Ran ESLint sequentially on all 20 packages and verified that they now pass cleanly (with warnings about unused variables in generated code).