Skip to content

test(storage): isolate environment in client tests #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 6 commits into from
Apr 16, 2026
+12 −8
Merged

test(storage): isolate environment in client tests #16664

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e252e2
test(storage): isolate environment in client tests
chalmerlowe Apr 15, 2026
75b6d2a
chore: update linting
chalmerlowe Apr 15, 2026
a6e4570
Update packages/google-cloud-storage/tests/unit/test_client.py
chalmerlowe Apr 16, 2026
92b3601
Update packages/google-cloud-storage/tests/unit/test_client.py
chalmerlowe Apr 16, 2026
0c622d7
Update packages/google-cloud-storage/tests/unit/test_client.py
chalmerlowe Apr 16, 2026
20f4309
test: removes unneeded line and applies linting
chalmerlowe Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/google-cloud-storage/tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ def test_ctor_wo_project(self):
PROJECT = "PROJECT"
credentials = _make_credentials(project=PROJECT)

client = self._make_one(credentials=credentials)
with mock.patch.dict("os.environ", {}, clear=True):
client = self._make_one(credentials=credentials)

self.assertEqual(client.project, PROJECT)
self.assertIsInstance(client._connection, Connection)
Expand Down Expand Up @@ -368,10 +369,11 @@ def test_ctor_w_custom_endpoint_use_auth(self):

def test_ctor_w_custom_endpoint_bypass_auth(self):
custom_endpoint = "storage-example.p.googleapis.com"
client = self._make_one(
client_options={"api_endpoint": custom_endpoint},
use_auth_w_custom_endpoint=False,
)
with mock.patch.dict("os.environ", {}, clear=True):
client = self._make_one(
client_options={"api_endpoint": custom_endpoint},
use_auth_w_custom_endpoint=False,
)
self.assertEqual(client._connection.API_BASE_URL, custom_endpoint)
self.assertEqual(client.project, None)
self.assertIsInstance(client._connection, Connection)
Expand All @@ -381,9 +383,11 @@ def test_ctor_w_custom_endpoint_w_credentials(self):
PROJECT = "PROJECT"
custom_endpoint = "storage-example.p.googleapis.com"
credentials = _make_credentials(project=PROJECT)
client = self._make_one(
credentials=credentials, client_options={"api_endpoint": custom_endpoint}
)
with mock.patch.dict("os.environ", {}, clear=True):
client = self._make_one(
credentials=credentials,
client_options={"api_endpoint": custom_endpoint},
)
self.assertEqual(client._connection.API_BASE_URL, custom_endpoint)
self.assertEqual(client.project, PROJECT)
self.assertIsInstance(client._connection, Connection)
Expand Down
Loading