Skip to content

chore: complete google-cloud-gke-hub migration#16674

Merged
jskeet merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-google-cloud-gke-hub
Apr 16, 2026
Merged

chore: complete google-cloud-gke-hub migration#16674
jskeet merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-google-cloud-gke-hub

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 16, 2026

  • Reformat with nox
  • Enable generation with librarian
  • Regenerate with librarian

@jskeet jskeet requested a review from parthea April 16, 2026 06:59
@jskeet jskeet requested a review from a team as a code owner April 16, 2026 06:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables code generation for GKE Hub by removing the skip_generate flag in librarian.yaml. Additionally, it updates the indentation and removes an empty issue_tracker field in .repo-metadata.json, and refactors imports in feature.py to use a grouped format. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit 4562388 into googleapis:main Apr 16, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants