Skip to content

chore: complete google-cloud-os-login migration#16675

Merged
jskeet merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-google-cloud-os-login
Apr 16, 2026
Merged

chore: complete google-cloud-os-login migration#16675
jskeet merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-google-cloud-os-login

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 16, 2026

  • Reformat with nox
  • Enable generation with librarian
  • Regenerate with librarian

@jskeet jskeet requested a review from parthea April 16, 2026 07:00
@jskeet jskeet requested a review from a team as a code owner April 16, 2026 07:00
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables generation for the OS Login v1 common types by removing the skip_generate flag in librarian.yaml. It also updates the repository metadata with an API description, removes the billing requirement flag, and enhances the README files with a brief service description. Additionally, import statements across several Python modules have been reorganized for better consistency. I have no feedback to provide as there were no review comments.

Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit 6069fae into googleapis:main Apr 16, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants