Repository navigation
Conversation
When credentials and client_options with credentials_file or api_key are both passed to BigtableMetricsExporter, strip credentials_file and api_key from a shallow copy of client_options before initializing MetricServiceClient.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigtableMetricsExporter initialization to prevent raising DuplicateCredentialArgs and mutating the caller's client_options when both resolved credentials and client_options (containing credentials_file or api_key) are provided. It handles both dictionary and ClientOptions object types, and includes corresponding unit tests. The review feedback highlights an inconsistency in how these two types are checked—using truthiness for dictionaries and explicit is not None checks for objects—and suggests standardizing on is not None checks for both to ensure consistent behavior.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
This is probably fine. If it fails it would fail loud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕