Skip to content

chore(bigtable): deprecate legacy handwritten Table and Backup admin methods - #19003

Merged
mutianf merged 2 commits into
mainfrom
deprecate-legacy-table-backup-admin
Nov 6, 2026
Merged

mutianf merged 2 commits into
mainfrom
deprecate-legacy-table-backup-admin

Conversation

@mutianf

@mutianf mutianf commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mutianf
mutianf requested a review from a team as a code owner November 5, 2026 18:45
@mutianf
mutianf added this pull request to stack #19004 November 5, 2026 18:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates several legacy methods in the Backup and Table classes of the google-cloud-bigtable package, directing users to use BigtableTableAdminClient instead. The changes add deprecation notices to docstrings and introduce runtime warnings.warn calls. Feedback highlights that the column_family and backup methods in table.py received docstring deprecation updates but are missing corresponding runtime warning calls, which should be added for consistency.

@mutianf
mutianf force-pushed the deprecate-legacy-table-backup-admin branch from e614a44 to 1815a71 Compare November 6, 2026 17:48
@mutianf
mutianf enabled stacked auto-merge (squash) November 6, 2026 17:48
@mutianf
mutianf disabled stacked auto-merge November 6, 2026 19:00
@mutianf
mutianf force-pushed the deprecate-legacy-table-backup-admin branch from 1815a71 to bc4e03a Compare November 6, 2026 19:00
Base automatically changed from deprecate-legacy-cluster-app-profile-admin to main November 6, 2026 21:22
…methods

Add DeprecationWarning and Sphinx deprecated directives to legacy handwritten admin methods on Table and Backup in favor of BigtableTableAdminClient.
…up admin methods

Keep only the Sphinx .. deprecated:: 2.30.0 docstring notices without emitting runtime warnings.
@mutianf
mutianf force-pushed the deprecate-legacy-table-backup-admin branch from bc4e03a to df4bc6f Compare November 6, 2026 21:22
@mutianf
mutianf enabled stacked auto-merge (squash) November 6, 2026 21:25
@mutianf
mutianf merged commit 5af3258 into main Nov 6, 2026
58 checks passed
@mutianf
mutianf deleted the deprecate-legacy-table-backup-admin branch November 6, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants