fix: sanitize mime_type and filename to prevent HTTP header injection in resumable upload#2371
Open
uchia6861-tech wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: sanitize mime_type and filename to prevent HTTP header injection in resumable upload#2371uchia6861-tech wants to merge 1 commit intogoogleapis:mainfrom
uchia6861-tech wants to merge 1 commit intogoogleapis:mainfrom
Conversation
… in resumable upload Sanitize user-supplied mime_type and filename values before they are interpolated into HTTP request headers in prepare_resumable_upload(). CR and LF characters in these values are stripped to prevent potential HTTP header injection. Added a _sanitize_header_value() helper that is applied to both the X-Goog-Upload-Header-Content-Type and X-Goog-Upload-File-Name headers.
Author
|
Sanitize user-supplied mime_type and filename values before they are CR and LF characters in these values are stripped to prevent potential |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in resumable upload
Sanitize user-supplied mime_type and filename values before they are interpolated into HTTP request headers in prepare_resumable_upload().
CR and LF characters in these values are stripped to prevent potential HTTP header injection. Added a _sanitize_header_value() helper that is applied to both the X-Goog-Upload-Header-Content-Type and X-Goog-Upload-File-Name headers.