Repository navigation
fix(tab): drop the language chip from tab list names - #67
Merged
Merged
Conversation
Every name in the player list carried a chip with the player's language (DE, EN, ...). It is not information other players need, and it took width from every row. Names now show only the rank chip, the Bedrock icon and the name; the tab list no longer looks up locales at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the language chip (
DE,EN, …) in front of every name in the tab list.TabName.formatno longer takes a locale; the row width (and so the padding to the wordmark) no longer counts the chip.TabListno longer queriesPlayerLocaleQueryor the client locale.GroundsProxyPluginstill usesPlayerLocaleQueryfor message translation, unchanged.DEchip../gradlew spotlessCheck :velocity:test: 127 tests green. Not yet seen on stage.