Repository navigation
fix(region): compare /region codes with CONTINENT, not REGION - #69
Merged
Merged
Conversation
The REGIONS catalogue is keyed by continent (eu), while REGION names the datacentre (de-nbg1). /region compared the two, so 'you are here' never matched and /region eu transferred a player to where they already were. Compare with CONTINENT and fall back to REGION when it is unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REGIONScatalogue is keyed by continent (eu=eu.geo.grnds.io:30565, built per continent in grounds-pulumicore/src/platform/argocd.ts), but/regioncompared its codes withREGION, the datacentre (de-nbg1). So "(you are here)" never showed and/region eutransferred a player to the continent they were already on.RegionCatalog.currentCode()returnsCONTINENT, falling back toREGIONwhen unset (a catalogue keyed by datacentre)./regionuses it for both the list marker and the already-here check.