Skip to content

Revert "Fix flaky specs on TruffleRuby" #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rymai merged 1 commit into from
Sep 30, 2026
Merged

Revert "Fix flaky specs on TruffleRuby" #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/listen/adapter/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def stop
private

def _stop
@run_thread.kill.join if @run_thread
@run_thread&.kill
@run_thread = nil
end

Expand Down
2 changes: 1 addition & 1 deletion lib/listen/adapter/darwin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def _process_event(dir, path)
end

def _stop
@worker_thread.kill.join if @worker_thread
@worker_thread&.kill
super
end
end
Expand Down
3 changes: 2 additions & 1 deletion spec/lib/listen/adapter/polling_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@
expect(snapshot).to receive(:invalidate).
with(:dir, '.', { recursive: true })

subject.start
t = Thread.new { subject.start }
sleep 0.25
t.kill
end
end

Expand Down
Loading