[codex] Fix global environment concurrency - #28
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
hainayanda
marked this pull request as ready for review
June 13, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GlobalValuesresolved instances while holding the registry lock. A resolver configured withresolveOn:could synchronously hop to another queue, access another global value, and deadlock waiting for the lock still held by the calling thread.Moving assignment notifications outside synchronization also allowed delayed notifications to refresh observers with stale resolvers.
Solution
GlobalEnvironmentstate.GlobalValuessubscript.Impact
resolveOn:resolvers can safely access other global values without cross-thread deadlocks, and observers ignore delayed stale assignment notifications. Public API behavior remains unchanged.Validation
xcrun swift test(23 tests passed)git diff --check