SRE-983: Split the effect-dns-hickory Rust crate and TypeScript package by TimDiekmann · Pull Request #9444 · hashintel/hash

TimDiekmann · 2026-08-29T19:41:25Z

🌟 What is the purpose of this PR?

libs/@local/effect-dns/hickory kept lib.rs and index.ts in one src. That is the layout napi expects, but it leaves both manifests in one directory. The crate moves to rust/, the package to typescript/, and napi build is pointed at the crate with --manifest-path.

Builds on SRE-982. Last of the splits; SRE-984 follows.

🔍 What does this change?

napi build --manifest-path ../rust/Cargo.toml replaces the implicit same-directory build. Nothing generated crosses the boundary otherwise: napi compiles the crate straight into the package's dist beside the declarations it emits, and tsc builds over both
The package declares the crate, so the package graph has an edge between them — without it a change to lib.rs would not select the package that compiles it
The package-name override in the crate's sync metadata is gone; the crate takes the generated @rust/ name and the package keeps @local/effect-dns-hickory

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

affected the execution graph, and the turbo.json's have been updated to reflect this

🐾 Next steps

SRE-984, which is blocked upstream rather than on us — a JavaScript package cannot express a dependency on a Cargo package in a way that satisfies yarn install, affectedPackages and turbo prune at once. The measurements are on that issue.

🛡 What tests cover this?

The package's existing vitest run, which exercises the compiled addon.

❓ How to test this?

turbo run build --filter=@local/effect-dns-hickory — the native addon and the declarations land in dist
turbo run lint:tsc lint:eslint test:unit --filter=@local/effect-dns-hickory
mise run sync:turborepo && git diff --exit-code '**/package.json'

The napi module kept `lib.rs` and `index.ts` in one `src`, which is the layout the tool expects but leaves both manifests in one directory. The crate moves to `rust/`, the package to `typescript/`, and `napi build` is pointed at the crate with `--manifest-path`. Unlike the other splits nothing generated crosses the boundary: napi compiles the crate straight into the package's `dist` beside the declarations it emits, and `tsc` builds over both. The package now depends on the crate. Without that the package graph has no edge between them, and a change to `lib.rs` would not select the package that compiles it.

vercel · 2026-08-29T19:41:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
hash	Ignored	Preview	Aug 29, 2026 8:02pm
hashdotdesign-tokens	Ignored	Preview	Aug 29, 2026 8:02pm
petrinaut	Skipped		Aug 29, 2026 8:02pm
petrinaut-docs	Skipped		Aug 29, 2026 8:02pm

codecov · 2026-08-29T19:45:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.99%. Comparing base (c7c0399) to head (dcb9fea).

Additional details and impacted files

@@                                      Coverage Diff                                       @@
##           t/sre-982-remove-the-graph-api-packages-javascript-surface    #9444      +/-   ##
==============================================================================================
- Coverage                                                       60.99%   60.99%   -0.01%     
==============================================================================================
  Files                                                            1447     1447              
  Lines                                                          144468   144468              
  Branches                                                         6687     6687              
==============================================================================================
- Hits                                                            88120    88118       -2     
- Misses                                                          55244    55246       +2     
  Partials                                                         1104     1104

Flag	Coverage Δ
apps.hash-ai-worker-ts	`1.99% <ø> (ø)`
apps.hash-api	`14.68% <ø> (ø)`
blockprotocol.type-system	`38.15% <ø> (ø)`
local.claude-hooks	`0.00% <ø> (ø)`
local.harpc-client	`51.49% <ø> (ø)`
local.hash-backend-utils	`3.27% <ø> (ø)`
local.hash-graph-sdk	`10.02% <ø> (ø)`
local.hash-isomorphic-utils	`12.22% <ø> (ø)`
rust.antsi	`2.36% <ø> (ø)`
rust.error-stack	`90.81% <ø> (ø)`
rust.harpc-codec	`84.70% <ø> (ø)`
rust.harpc-net	`96.21% <ø> (-0.04%)`	⬇️
rust.harpc-tower	`67.03% <ø> (ø)`
rust.harpc-types	`0.00% <ø> (ø)`
rust.harpc-wire-protocol	`92.23% <ø> (ø)`
rust.hash-codec	`72.76% <ø> (ø)`
rust.hash-config	`100.00% <ø> (ø)`
rust.hash-graph-api	`19.76% <ø> (ø)`
rust.hash-graph-authentication	`97.00% <ø> (ø)`
rust.hash-graph-authorization	`63.14% <ø> (ø)`
rust.hash-graph-embeddings	`91.88% <ø> (ø)`
rust.hash-graph-postgres-store	`32.02% <ø> (ø)`
rust.hash-graph-store	`48.41% <ø> (ø)`
rust.hash-graph-temporal-versioning	`50.18% <ø> (ø)`
rust.hash-graph-types	`0.00% <ø> (ø)`
rust.hash-graph-validation	`84.71% <ø> (ø)`
rust.hash-middleware	`92.19% <ø> (ø)`
rust.hashql-ast	`89.63% <ø> (ø)`
rust.hashql-compiletest	`28.39% <ø> (ø)`
rust.hashql-core	`78.95% <ø> (ø)`
rust.hashql-diagnostics	`72.51% <ø> (ø)`
rust.hashql-eval	`79.82% <ø> (ø)`
rust.hashql-hir	`89.09% <ø> (ø)`
rust.hashql-mir	`87.92% <ø> (ø)`
rust.hashql-syntax-jexpr	`94.04% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codspeed-hq · 2026-08-29T19:49:51Z

Merging this PR will not alter performance

✅ 98 untouched benchmarks

_{Comparing t/sre-983-split-the-effect-dns-hickory-rust-crate-and-typescript (9c2a890) with main (73cbb0b)¹}

No successful run was found on t/sre-982-remove-the-graph-api-packages-javascript-surface (c7c0399) during the generation of this report, so main (73cbb0b) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

cursor · 2026-08-29T19:52:52Z

PR Summary

Low Risk
Build and monorepo layout only; native build output path and workspace wiring change, with no described runtime or API behavior changes.

Overview
Splits effect-dns-hickory into sibling rust/ and typescript/ workspaces so the Cargo crate and npm package no longer share one directory.

The workspace member moves to libs/@local/effect-dns/hickory/rust, and napi build now targets that crate via --manifest-path ../rust/Cargo.toml while still emitting the native addon into the TypeScript package’s dist. A new @rust/effect-dns-hickory workspace package wires the crate into Yarn/Turbo (clippy/diagram scripts), and @local/effect-dns-hickory depends on it so Rust changes participate in the JS task graph.

Turborepo sync metadata is removed from the crate’s Cargo.toml in favor of the generated @rust/ name; TS path aliases and yarn.lock resolutions point at hickory/typescript. License files are added under typescript/.

^{Reviewed by Cursor Bugbot for commit 9c2a890. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit dcb9fea. Configure here.}

github-advanced-security · 2026-08-29T20:04:52Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

github-actions · 2026-08-29T21:20:02Z

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2002	$$27.3 \mathrm{ms} \pm 217 \mathrm{μs}\left({\color{gray}-0.305 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$3.47 \mathrm{ms} \pm 29.4 \mathrm{μs}\left({\color{gray}-1.744 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 1002	$$12.2 \mathrm{ms} \pm 101 \mathrm{μs}\left({\color{gray}-0.472 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 3314	$$43.0 \mathrm{ms} \pm 472 \mathrm{μs}\left({\color{gray}0.621 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$14.0 \mathrm{ms} \pm 121 \mathrm{μs}\left({\color{lightgreen}-5.737 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 1527	$$23.4 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-0.213 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 2078	$$28.0 \mathrm{ms} \pm 247 \mathrm{μs}\left({\color{gray}-1.396 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.74 \mathrm{ms} \pm 24.0 \mathrm{μs}\left({\color{gray}-1.954 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 1033	$$13.2 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{gray}-0.385 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_medium

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 102	$$3.82 \mathrm{ms} \pm 31.5 \mathrm{μs}\left({\color{gray}0.799 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.98 \mathrm{ms} \pm 19.0 \mathrm{μs}\left({\color{gray}-0.256 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 52	$$3.36 \mathrm{ms} \pm 21.6 \mathrm{μs}\left({\color{gray}-0.856 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 269	$$5.19 \mathrm{ms} \pm 42.6 \mathrm{μs}\left({\color{gray}-0.435 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$3.51 \mathrm{ms} \pm 16.6 \mathrm{μs}\left({\color{gray}-0.140 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 108	$$4.11 \mathrm{ms} \pm 22.5 \mathrm{μs}\left({\color{gray}-0.932 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 133	$$4.39 \mathrm{ms} \pm 27.4 \mathrm{μs}\left({\color{gray}-1.303 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.44 \mathrm{ms} \pm 21.1 \mathrm{μs}\left({\color{gray}-0.560 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 63	$$4.07 \mathrm{ms} \pm 32.9 \mathrm{μs}\left({\color{gray}-0.350 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_none

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2	$$2.66 \mathrm{ms} \pm 18.6 \mathrm{μs}\left({\color{gray}-0.552 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.50 \mathrm{ms} \pm 15.0 \mathrm{μs}\left({\color{gray}-1.474 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 2	$$2.65 \mathrm{ms} \pm 21.3 \mathrm{μs}\left({\color{gray}-0.210 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 8	$$2.94 \mathrm{ms} \pm 17.7 \mathrm{μs}\left({\color{gray}-1.495 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.73 \mathrm{ms} \pm 18.0 \mathrm{μs}\left({\color{gray}0.173 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 3	$$2.90 \mathrm{ms} \pm 15.6 \mathrm{μs}\left({\color{gray}-0.139 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_small

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 52	$$3.05 \mathrm{ms} \pm 17.3 \mathrm{μs}\left({\color{gray}0.269 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.74 \mathrm{ms} \pm 16.0 \mathrm{μs}\left({\color{gray}-0.016 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 26	$$3.00 \mathrm{ms} \pm 17.2 \mathrm{μs}\left({\color{gray}-0.350 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 94	$$3.43 \mathrm{ms} \pm 21.4 \mathrm{μs}\left({\color{gray}-0.936 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$2.96 \mathrm{ms} \pm 17.4 \mathrm{μs}\left({\color{gray}0.004 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 27	$$3.28 \mathrm{ms} \pm 22.2 \mathrm{μs}\left({\color{gray}0.057 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 66	$$3.40 \mathrm{ms} \pm 25.1 \mathrm{μs}\left({\color{gray}-0.553 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.94 \mathrm{ms} \pm 15.1 \mathrm{μs}\left({\color{gray}0.447 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 29	$$3.34 \mathrm{ms} \pm 19.9 \mathrm{μs}\left({\color{gray}-1.036 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_complete

Function	Value	Mean	Flame graphs
entity_by_id;one_depth	1 entities	$$41.6 \mathrm{ms} \pm 209 \mathrm{μs}\left({\color{gray}0.565 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	10 entities	$$32.3 \mathrm{ms} \pm 252 \mathrm{μs}\left({\color{gray}-2.784 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	25 entities	$$35.4 \mathrm{ms} \pm 253 \mathrm{μs}\left({\color{gray}1.16 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	5 entities	$$37.0 \mathrm{ms} \pm 1.19 \mathrm{ms}\left({\color{red}19.6 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	50 entities	$$40.4 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}0.160 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	1 entities	$$49.0 \mathrm{ms} \pm 270 \mathrm{μs}\left({\color{gray}0.852 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	10 entities	$$39.4 \mathrm{ms} \pm 279 \mathrm{μs}\left({\color{gray}0.542 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	25 entities	$$90.6 \mathrm{ms} \pm 819 \mathrm{μs}\left({\color{gray}1.64 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	5 entities	$$45.6 \mathrm{ms} \pm 4.03 \mathrm{ms}\left({\color{red}39.2 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	50 entities	$$272 \mathrm{ms} \pm 1.29 \mathrm{ms}\left({\color{gray}-1.179 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	1 entities	$$10.4 \mathrm{ms} \pm 70.8 \mathrm{μs}\left({\color{gray}0.524 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	10 entities	$$10.5 \mathrm{ms} \pm 79.2 \mathrm{μs}\left({\color{gray}1.23 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	25 entities	$$10.6 \mathrm{ms} \pm 86.4 \mathrm{μs}\left({\color{gray}-0.267 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	5 entities	$$10.3 \mathrm{ms} \pm 72.1 \mathrm{μs}\left({\color{gray}0.457 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	50 entities	$$10.3 \mathrm{ms} \pm 62.4 \mathrm{μs}\left({\color{gray}-1.509 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_linkless

Function	Value	Mean	Flame graphs
entity_by_id	1 entities	$$10.5 \mathrm{ms} \pm 78.3 \mathrm{μs}\left({\color{gray}0.656 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$10.4 \mathrm{ms} \pm 64.1 \mathrm{μs}\left({\color{gray}0.335 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	100 entities	$$10.4 \mathrm{ms} \pm 61.9 \mathrm{μs}\left({\color{gray}-0.108 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1000 entities	$$10.4 \mathrm{ms} \pm 62.0 \mathrm{μs}\left({\color{gray}0.411 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10000 entities	$$10.7 \mathrm{ms} \pm 78.2 \mathrm{μs}\left({\color{gray}1.29 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity

Function	Value	Mean	Flame graphs
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/block/v/1`	$$10.7 \mathrm{ms} \pm 62.8 \mathrm{μs}\left({\color{gray}-0.717 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/book/v/1`	$$10.7 \mathrm{ms} \pm 62.6 \mathrm{μs}\left({\color{gray}-0.015 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/building/v/1`	$$10.9 \mathrm{ms} \pm 101 \mathrm{μs}\left({\color{gray}1.63 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/organization/v/1`	$$10.7 \mathrm{ms} \pm 70.2 \mathrm{μs}\left({\color{gray}0.589 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/page/v/2`	$$10.7 \mathrm{ms} \pm 73.4 \mathrm{μs}\left({\color{gray}0.301 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/person/v/1`	$$10.7 \mathrm{ms} \pm 71.3 \mathrm{μs}\left({\color{gray}-1.764 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/playlist/v/1`	$$10.7 \mathrm{ms} \pm 75.1 \mathrm{μs}\left({\color{gray}1.03 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/song/v/1`	$$10.7 \mathrm{ms} \pm 73.2 \mathrm{μs}\left({\color{gray}0.414 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1`	$$10.7 \mathrm{ms} \pm 74.2 \mathrm{μs}\left({\color{gray}0.207 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity_type

Function	Value	Mean	Flame graphs
get_entity_type_by_id	Account ID: `bf5a9ef5-dc3b-43cf-a291-6210c0321eba`	$$8.07 \mathrm{ms} \pm 46.1 \mathrm{μs}\left({\color{gray}-0.538 \mathrm{\%}}\right) $$	Flame Graph

representative_read_multiple_entities

Function	Value	Mean	Flame graphs
entity_by_property	traversal_paths=0	0	$$54.7 \mathrm{ms} \pm 440 \mathrm{μs}\left({\color{gray}-0.510 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$108 \mathrm{ms} \pm 665 \mathrm{μs}\left({\color{gray}0.685 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$62.6 \mathrm{ms} \pm 554 \mathrm{μs}\left({\color{gray}1.44 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$71.7 \mathrm{ms} \pm 521 \mathrm{μs}\left({\color{gray}-0.704 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$80.6 \mathrm{ms} \pm 471 \mathrm{μs}\left({\color{gray}0.146 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$86.5 \mathrm{ms} \pm 637 \mathrm{μs}\left({\color{gray}0.386 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=0	0	$$41.2 \mathrm{ms} \pm 325 \mathrm{μs}\left({\color{gray}-1.057 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$69.8 \mathrm{ms} \pm 455 \mathrm{μs}\left({\color{gray}-1.173 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$47.5 \mathrm{ms} \pm 366 \mathrm{μs}\left({\color{gray}-0.224 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$57.0 \mathrm{ms} \pm 460 \mathrm{μs}\left({\color{gray}0.433 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$59.3 \mathrm{ms} \pm 489 \mathrm{μs}\left({\color{gray}-0.178 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$59.5 \mathrm{ms} \pm 475 \mathrm{μs}\left({\color{gray}0.522 \mathrm{\%}}\right) $$

scenarios

Function	Value	Mean	Flame graphs
full_test	query-limited	$$110 \mathrm{ms} \pm 720 \mathrm{μs}\left({\color{lightgreen}-6.984 \mathrm{\%}}\right) $$	Flame Graph
full_test	query-unlimited	$$123 \mathrm{ms} \pm 562 \mathrm{μs}\left({\color{gray}-3.640 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-limited	$$17.9 \mathrm{ms} \pm 166 \mathrm{μs}\left({\color{gray}0.043 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-unlimited	$$530 \mathrm{ms} \pm 1.37 \mathrm{ms}\left({\color{gray}0.470 \mathrm{\%}}\right) $$	Flame Graph

TimDiekmann self-assigned this Aug 29, 2026

TimDiekmann deployed to pull-request August 29, 2026 19:42 — with GitHub Actions Active

vercel Bot deployed to Preview – hashdotdesign-tokens August 29, 2026 19:44 View deployment

vercel Bot deployed to Preview – petrinaut-docs August 29, 2026 19:44 View deployment

vercel Bot deployed to Preview – petrinaut August 29, 2026 19:45 View deployment

TimDiekmann marked this pull request as ready for review August 29, 2026 19:52

TimDiekmann requested a review from a team as a code owner August 29, 2026 19:52

TimDiekmann requested a review from a team August 29, 2026 19:52

vercel Bot deployed to Preview – hash August 29, 2026 19:55 View deployment

cursor Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread libs/@local/effect-dns/hickory/typescript/package.json

Comment thread libs/@local/effect-dns/hickory/rust/package.json

SRE-983: Give the hickory crate its clippy scripts

9c2a890

vercel Bot temporarily deployed to Preview – petrinaut August 29, 2026 20:01 Inactive

vercel Bot temporarily deployed to Preview – petrinaut-docs August 29, 2026 20:01 Inactive

TimDiekmann deployed to pull-request August 29, 2026 20:02 — with GitHub Actions Active

indietyp approved these changes Aug 31, 2026

View reviewed changes

vilkinsons approved these changes Aug 31, 2026

View reviewed changes

TimDiekmann added this pull request to the merge queue Aug 31, 2026

github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Aug 31, 2026

TimDiekmann added this pull request to the merge queue Aug 31, 2026

Merged via the queue into main with commit aae1779 Aug 31, 2026
220 checks passed

TimDiekmann deleted the t/sre-983-split-the-effect-dns-hickory-rust-crate-and-typescript branch August 31, 2026 10:42

Uh oh!

Conversation

TimDiekmann commented Aug 29, 2026

🌟 What is the purpose of this PR?

🔍 What does this change?

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

📜 Does this require a change to the docs?

🕸️ Does this require a change to the Turbo Graph?

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

Uh oh!

vercel Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

cursor Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI commented Aug 29, 2026

What Enabling Code Scanning Means:

Uh oh!

github-actions Bot commented Aug 29, 2026

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

policy_resolution_medium

policy_resolution_none

policy_resolution_small

read_scaling_complete

read_scaling_linkless

representative_read_entity

representative_read_entity_type

representative_read_multiple_entities

scenarios

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Aug 29, 2026 •

edited

Loading

codecov Bot commented Aug 29, 2026 •

edited

Loading

codspeed-hq Bot commented Aug 29, 2026 •

edited

Loading

cursor Bot commented Aug 29, 2026 •

edited

Loading