Follow hlint suggestion: redundant bracket#11918
Open
philderbeast wants to merge 12 commits into
Open
Conversation
ffaf1
approved these changes
May 31, 2026
Comment on lines
-149
to
+159
| ( [ optionNumJobs | ||
| buildNumJobs | ||
| (\v flags -> flags{buildNumJobs = v}) | ||
| , option | ||
| [] | ||
| ["semaphore"] | ||
| "Use the specified semaphore so GHC can compile components in parallel" | ||
| buildUseSemaphore | ||
| (\v flags -> flags{buildUseSemaphore = v}) | ||
| (reqArg' "SEMAPHORE" Flag flagToList) | ||
| ] | ||
| ) | ||
| [ optionNumJobs | ||
| buildNumJobs | ||
| (\v flags -> flags{buildNumJobs = v}) | ||
| , option | ||
| [] | ||
| ["semaphore"] | ||
| "Use the specified semaphore so GHC can compile components in parallel" | ||
| buildUseSemaphore | ||
| (\v flags -> flags{buildUseSemaphore = v}) | ||
| (reqArg' "SEMAPHORE" Flag flagToList) | ||
| ] |
Collaborator
There was a problem hiding this comment.
This cannot be correct right? It is a function argument, it should be tabbed right?
| let name = prettyShow $ mungedName x | ||
| in name == "Cabal" || name == "base" | ||
| ) | ||
| (componentPackageDeps clbi) |
zlonast
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores HLint's "redundant bracket" suggestion so that this will be suggested by our CI linting.
I'll squash commits before applying the merge label if this pull request is approved.