Skip to content

Apply the explicit Ask engine when reopening a map - #147

Open
rudycelekli wants to merge 1 commit into
haydenschmitty:mainfrom
rudycelekli:fix/honor-ask-engine-on-reopen
Open

rudycelekli wants to merge 1 commit into
haydenschmitty:mainfrom
rudycelekli:fix/honor-ask-engine-on-reopen

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Opening an existing map with --engine codex reused the running Claude Code server. Ask continued to route through Claude Code, even though the caller explicitly selected Codex. The reverse switch has the same problem.

Fix

The local server reports the engine explicitly selected when it started. Open restarts that map server when the caller requests a different engine, then reuses the same address. Repeating the same selection keeps the server running.

Verification

  • The interactive CLI regression failed on the old code, which kept reporting Claude Code. With the fix it switches to Codex, keeps the map URL, and does not restart again when the engine selection matches.
  • Built a real Agent-Reach map and repeated the switch on localhost using version-only test executables. No Ask request or external model call ran.
  • npm test -- --test-concurrency=2 on macOS, Node 26.12.1: 488 passed, 1 skipped.
  • claude plugin validate . passed.

GitHub's engine-switch regression passed on all six matrix jobs. The Node 18 Linux shard failed an existing route-parser performance assertion at 2,043 ms against a 2,000 ms limit. Repository admin access is required to rerun the shard. Hosted failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant