Repository navigation
Conversation
Owner
|
本轮独立 focused 7/0 通过,去除伪 canonical instrumentId 的方向合理。但与最新 main 的 financial-evidence.ts 存在组合冲突,涉及 canonical helpers 及刚合入 #182 的时间归一化逻辑。请基于最新 main 更新,保留两者契约并重跑 evidence 全量与 typecheck,再进行合并。 |
Owner
|
同步最新 main:#353 已合入(038f20cf2d87e3575ffbe5469967bdf6ef960dc8),现在已有免 API key 的 Yahoo Finance 备用数据源。请同步 main 后复用现有 provider router / market-data 接口,不再把支持范围内的行情验收统一卡在 Longbridge/Massive 凭证上。 支持范围是美股延迟报价、日/周 K 线和简要公司资料;不支持券商账户/持仓、财报、新闻、期权及分钟行情。保留实际 provider、时间与 delayed 标记,不能用缺失数据冒充 0 或“没有事件”。文档明确它是非官方、个人使用范围的接口,可能限流。 针对本 PR:请补验 Yahoo ticker/alias 经网关后进入金融证据的 canonical instrumentId,缺失身份时仍不能猜测。 参考:接入说明 · 适配器。请区分 fixture 与真实联网结果;连接卡显示 connected 本身不证明实际取数成功。此评论同步新基线,不替代原有 review 或验收结论。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么:金融证据从 provenance 或规范化结果数据中读取 instrumentId;不再将 provider symbol 推导为 canonical ID,缺少 canonical ID 时省略字段。\n\n为什么:AAPL.US、600519.SH 等是 provider ticker,不是 Folio 的稳定证券身份;错误归类会造成 evidence/fact 关联身份不一致。\n\n验证:Windows / Bun 1.4.2;bun test packages/shared --isolate → 1115 passed / 0 failed;bun run typecheck → core、i18n、shared、ui、electron 全部 exit 0;bun test packages/shared/src/evidence/financial-evidence.test.ts → 7 passed / 0 failed;改动源文件 secret pattern scan 无命中。无可见 UI 变化;未运行 live provider smoke,本次没有改 Provider 接线。