Repository navigation
fix(ios): open the modal picker without AppDelegate.window - #978
Open
AlicanAkyol wants to merge 1 commit into
Open
AlicanAkyol wants to merge 1 commit into
AlicanAkyol wants to merge 1 commit into
Conversation
openPicker read [UIApplication sharedApplication].delegate.window, which apps on the UIKit scene life cycle (React Native 0.88 template, Expo SDK 58) do not have, so opening the modal picker threw '-[AppDelegate window]: unrecognized selector'. Use RCTKeyWindow() from React's RCTUtils.h.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openPickergets the root view controller through[UIApplication sharedApplication].delegate.window.With the UIKit scene life cycle the window belongs to the scene delegate and the AppDelegate has no
windowproperty. That is the React Native 0.88 template, and Expo SDK 58 (SDK 57 withenableSceneSupport). Apple requires the scene life cycle for apps built with the iOS 27 SDK (TN3187), and App Store uploads need that SDK from April 2027. In such an app, opening the modal picker throws:This uses
RCTKeyWindow().rootViewControllerfrom<React/RCTUtils.h>instead, so the picker is presented from the same controller as before. Behaviour is unchanged on the classic AppDelegate life cycle.Testing: I reproduced this crash pattern, and confirmed the same fix, with two other libraries on a fresh React Native 0.88.0-rc.4 app in the iOS simulator (react-native-blob-util#498, invertase/react-native-google-mobile-ads#911, the latter now approved). I could not run it with this library on 0.88: 5.0.13 doesn't build there yet (
'RCTComponent.h' file not found), which is a separate issue.Found while adding a UIScene check to NativeKeel, a React Native health-check CLI I maintain.