Skip to content

Add autoclaim to team gifts config - #179

Merged
andresfelipemendez merged 3 commits into
mainfrom
auto-claim-team-gifts
Sep 29, 2026
Merged

andresfelipemendez merged 3 commits into
mainfrom
auto-claim-team-gifts

Conversation

@andresfelipemendez

Copy link
Copy Markdown
Contributor

Add autoclaim to team gifts config

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The config schema/docs appear out of sync (the JSON schema for TeamGiftsConfigGift disallows auto_claim), which can cause validation/tooling to reject updated configs.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an auto_claim configuration flag to the team gifts configuration model so team gift definitions can express whether they should be automatically claimed.

Changes:

  • Added AutoClaim bool (json:"auto_claim,omitempty") to TeamGiftsConfigGift in teams.go.
File summaries
File Description
teams.go Extends the team gifts config struct with an auto_claim JSON field.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread teams.go
Copilot AI review requested due to automatic review settings September 7, 2026 18:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces a new config/API field without updating associated schema validation and committed generated outputs, leaving the repo’s contracts and artifacts out of sync.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

teams.go:106

  • TeamGiftsConfigGift adds the auto_claim field, but the Satori JSON schema for Hiro-Teams currently has additionalProperties: false and does not include auto_claim under TeamGiftsConfigGift, which will cause schema validation to reject configs that use this new setting. Please update schemas/05-Hiro-Teams.json (and the example definitions/05-Hiro-Teams.json if it’s intended to demonstrate the full shape) to include auto_claim as a boolean property for gift configs.
	AutoClaim            bool                         `json:"auto_claim,omitempty"`
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread hiro.proto
Copilot AI review requested due to automatic review settings September 17, 2026 11:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a backward-compatible additive API/config field and the proto/OpenAPI/Go model updates appear consistent.

Review details
  • Files reviewed: 3/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 28, 2026 19:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Update the team configuration JSON schema to accept auto_claim.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Copilot AI review requested due to automatic review settings September 29, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The team-gifts JSON schema rejects configurations containing auto_claim.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

@andresfelipemendez
andresfelipemendez merged commit 7593ee9 into main Sep 29, 2026
2 checks passed
@andresfelipemendez
andresfelipemendez deleted the auto-claim-team-gifts branch September 29, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants