Repository navigation
Add autoclaim to team gifts config - #179
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The config schema/docs appear out of sync (the JSON schema for TeamGiftsConfigGift disallows auto_claim), which can cause validation/tooling to reject updated configs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an auto_claim configuration flag to the team gifts configuration model so team gift definitions can express whether they should be automatically claimed.
Changes:
- Added
AutoClaim bool(json:"auto_claim,omitempty") toTeamGiftsConfigGiftinteams.go.
File summaries
| File | Description |
|---|---|
| teams.go | Extends the team gifts config struct with an auto_claim JSON field. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a new config/API field without updating associated schema validation and committed generated outputs, leaving the repo’s contracts and artifacts out of sync.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
teams.go:106
- TeamGiftsConfigGift adds the auto_claim field, but the Satori JSON schema for Hiro-Teams currently has
additionalProperties: falseand does not includeauto_claimunderTeamGiftsConfigGift, which will cause schema validation to reject configs that use this new setting. Please updateschemas/05-Hiro-Teams.json(and the exampledefinitions/05-Hiro-Teams.jsonif it’s intended to demonstrate the full shape) to includeauto_claimas a boolean property for gift configs.
AutoClaim bool `json:"auto_claim,omitempty"`
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
7540c6b to
ac5b624
Compare
ac5b624 to
418d7dc
Compare

Add autoclaim to team gifts config