Repository navigation
Thread a database handle through Init - #181
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the README usage examples for the new required Init argument.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Init to accept and forward a database handle to the plugin entrypoint.
Changes:
- Adds
*sql.DBto theInitsignature. - Updates the plugin type assertion and invocation.
- Documents the API change in the changelog.
| File | Summary |
|---|---|
CHANGELOG.md |
Documents the updated Init API. |
base.go |
Threads the database handle through Init. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tolgatolgay
self-requested a review
September 28, 2026 13:14
tolgatolgay
approved these changes
Sep 28, 2026
|
|
||
| func InitModule(ctx context.Context, logger runtime.Logger, db *sql.DB, nk runtime.NakamaModule, initializer runtime.Initializer) error { | ||
| systems, err := hiro.Init(ctx, logger, nk, initializer, "hiro.bin", "LicenseKey", | ||
| systems, err := hiro.Init(ctx, logger, db, nk, initializer, "hiro.bin", "LicenseKey", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Init now takes a
*sql.DBand passes it to the plugin entrypoint, so gameplay systems can reach the database directly instead of only through the runtime module. The plugin type assertion is updated to match.