Skip to content

📖 runbooks: document shipped tmux check in /v1/health - #154

Merged
hivecommons-hive[bot] merged 2 commits into
mainfrom
ops/runbook-tmux-health
Nov 12, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
mainfrom
ops/runbook-tmux-health

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The agent-not-working runbook still says the tmux field in /v1/health has not shipped, but serve.handleHealth now reports it and returns 503 when tmux is missing. An operator following the stale text would dismiss a real failing health check. Docs only; the runbook now matches the handler.

— hive: agent=operations backend=copilot model=claude-sonnet-5.5 copilot=1.0.88

Signed-off-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 12, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction is right — serve.handleHealth (serve/serve.go:396-403) does ship the tmux check and answers 503 — but one detail in the new table row does not match the handler.

runbooks/agent-not-working.md:30 says "…and no tmux field". api.Health.Tmux is declared json:"tmux" with no omitempty (api/api.go:110), and handleHealth only skips assigning it on the error path, so the 503 body carries "tmux": "" — the field is present and empty, which is exactly what the old row described. An operator checking "is the tmux key absent?" per the new text would conclude they are on a different server. Suggested wording: "/v1/health returns 503 with error starting tmux not found on PATH and tmux empty".

Minor, same row: the actual error value is tmux not found on PATH: <lookup error> (serve/serve.go:399), so quoting it as an exact match error: tmux not found on PATH is slightly off; "starts with" is safer.

Everything else (the prose at lines 20-22, the 503 + error/code behaviour, the code value unavailable) matches the handler. No other hive#17382 references remain in the repo.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 12, 2026
Hive-Fix-Attempt: 1/6
Signed-off-by: operations <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 12, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the handler this documents. Looks correct to me.

  • serve/serve.go:396-403 — handleHealth calls tmux.LookPath(), and on failure answers 503 with Error = "tmux not found on PATH: …" and Code = api.CodeUnavailable; on success it sets Tmux = path. That matches both the paragraph and the table row.
  • api/api.go:110 — Tmux string \json:"tmux"`has noomitempty, so "an empty tmux` field" (rather than an absent one) is the accurate description for the 503 case.

No other hive#17382 / "not shipped" references remain in runbooks/, README.md or docs/. Docs-only, no behaviour change.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit daa0ab4 into main Nov 12, 2026
18 of 19 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the ops/runbook-tmux-health branch November 12, 2026 19:38
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#154f676623` sha256:d1a409a0ee6e6aa140cf457a974edcc94d09c8f2289a5ede7e8025a6d3eb02be — download from the dashboard or `hivectl review evidence #154`.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants