Repository navigation
[scanner] docs: document review.perspectives_source and add changelog fragment #17990
Description
Part of #17975. Target branch: v5. Blocked by #17989 (the feature is complete end-to-end).
Goal
Document review.perspectives_source and add the changelog fragment.
Changes (≤5 files)
src/docs/review-swarm.md: in## Perspectives(and the## Configurationtable), add a subsection "Live-linked perspectives (review.perspectives_source)". It covers the YAML for the config and for thekind: ReviewPerspectivesfile; that the file holds names and focus only (combined_perspectives,plan_matchandmax_perspectives_per_prstay operator-owned); that the source wins and inlinereview.perspectivesis the fallback; the fallback order (last-known-good, then inline, then built-ins), with a malformed doc keeping last-known-good and raising a warning; resolution at startup and on every reload; how the relay set is reinstalled; that heads waiting on a removed perspective settle (review: changing review.perspectives strands mid-review PRs: heads wait forever on removed perspectives #14905); and that the dashboard section is read-only while linked.src/docs/agent-configuration.md: in "Live-linked agent definitions (definition_source)", add a short cross-reference noting thatreview.perspectives_sourceuses the same trust gate (GitHubPromptAllowedseed-only allowlist) and the same resolve points.src/hive.yaml.example: add a commentedperspectives_source:block in the review swarm section (around thecombined_perspectivesexample, ~L846–870), plus a pointer to the file format.changelog.d/added-17975-review-perspectives-source.md: one-bullet perchangelog.d/README.md.
Acceptance criteria
- The docs describe the behaviour that shipped in the earlier children; no behaviour change.
- The
settingHelpMark('review-swarm', …)anchors still resolve, and any docs link-check or changelog guard in CI passes. - If the earlier children already documented some of this, this child only fills the gaps and adds the changelog fragment.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
Activity
definition_source) #17975hivecommons-hive commentedon Nov 13, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.Claim history
Danathar(contributor on hive hosted-available-oke-11-placeholder-r05x)Danathar(contributor; lease revoked)scanner(agent on hive hosted-available-oke-11-placeholder-r05x)Danathar commentedon Nov 13, 2026
Holding this docs child until the behaviour it documents is on
v5. As ofupstream/v5@ 88f6c9c (v5.240.0):kind: ReviewPerspectivesparser ([scanner] review: add review.perspectives_source config and ReviewPerspectives document parser #17986 / PR ✨ feat(review): add review.perspectives_source config and ReviewPerspectives document parser #17994) and theperspsrcresolver with last-known-good fallback andEffectivePerspectives()consumers ([scanner] review: add perspsrc resolver with last-known-good fallback; consumers read the resolved perspective set #17987 / PR ✨ review: add perspsrc resolver with last-known-good fallback #18011). Both already haveCHANGELOG.mdentries.perspsrc.ApplyToConfigis not called fromsrc/cmd/hiveon v5; onlydefsrc.ApplyToConfigis.The acceptance criteria say the docs should describe behaviour that has shipped, with no behaviour change. Right now the startup/reload, relay reinstall and dashboard read-only sections would describe code that isn't on v5 yet. This should be picked up again once #17988 and #17989 merge.
— hive: backend=claude
🐝 Hive Agent:
contributor| SHA:88f6c9cefhivecommons-hive commentedon Nov 13, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #17989 is closed. This issue is actionable again.
github-actions commentedon Nov 13, 2026
@hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.clubanderson commentedon Nov 13, 2026
Resolved by #18078, merged to v5 as a2cb35a.
src/docs/review-swarm.mdgains a "Live-linked perspectives" section,agent-configuration.mdnotes the shared seed-only gate, andhive.yaml.examplecarries a commentedperspectives_source:block. Parent #17975 is now closed as complete.