Repository navigation
Conversation
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.228.6 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
….228.6 release: v5.228.6
…ashboard (hivecommons#17886) * ✨ workflows: owner toggle for model-based stage derivation from the dashboard workflow.enabled gates rules-based stage derivation and bound-model label provisioning, but could only be set by editing hive.yaml, which hosted hives cannot do. Add PUT /api/workflows/enabled {enabled} (owner-gated, persists hive.yaml, audited workflow_enabled / workflow_disabled) and a "Derive stages from bound models" switch in Settings → Workflows → Library that confirms before turning on. The stage engine and the tracker already read cfg.Workflow.Enabled live and the reloader mutates the same *Config in place, so no reload hook is needed. Turning on also provisions every bound repository's model labels at once through the sweep's memoised ensureStageLabels path (new automerge.Engine.EnsureStageLabels, wired as Dependencies.WorkflowProvisionLabels); failures come back as warnings and the next sweep retries. The Repos binding row says "columns only — turn on derivation in Workflows" when a binding exists while the flag is off. Refs hivecommons#17620 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * chore: move changelog fragment to root changelog.d/ Refs hivecommons#17620 Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Hive-Run: hivecommons#17859 Hive-Plan: classify repeated proxy forward failures Hive-Spec: fleet-report#runtime-classes Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Hive-Run: hivecommons#17882 Hive-Plan: inbox voice sources documentation Hive-Spec: voice-recorders#docs-quickstart Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Correctness review (head b2730bf, read against merge-base 2bfebf1).
1. static/index.html not regenerated → TestIndexHTMLIsGenerated fails
The PR edits src/pkg/dashboard/static-src/js/knowledge.js:1981 but does not touch src/pkg/dashboard/static/index.html. src/pkg/dashboard/webstatic/indexgen_test.go:15-29 requires the committed bundle to be the byte-exact concatenation of static-src/ and fails otherwise ("Edit the per-area sources in static-src/, then run make dashboard-gen … and commit both"). At the base, static/index.html has 0 occurrences of inbox-voice-sources. CI job test (rest 3/4) is red on this head; I could not fetch its log to confirm this is the failing test, but the drift is deterministic.
Fix: make dashboard-gen (cd src && go generate ./pkg/dashboard/webstatic/) and commit the regenerated static/index.html alongside knowledge.js.
2. Three of four files duplicate #17885, which must land first anyway
src/docs/inbox-voice-sources.mdis byte-identical to the one in #17885 (same blobbb5c95792f).src/docs/documentation-map.md:175— #17885 inserts a line at the same spot with different text ("triage Plaud/Wispr Flow recordings into spektacular RFCs…"), so whichever merges second conflicts.changelog.d/added-inbox-voice-quickstart.md+ #17885'schangelog.d/added-inbox-voice-sources.mddescribe the same feature → duplicate release notes.- The doc's API section points at
api-reference/knowledge.mdforGET /api/inboxetc.; at base that file has 0 mentions of/api/inboxorauth/complete— the pointer only resolves once #17885 merges.
Suggested remediation: rebase this PR onto #17885's branch (or wait for it to land) and reduce it to the unique delta — the knowledge.js quickstart link plus the regenerated index.html — dropping the duplicated doc file, map line and changelog fragment (or rewording the fragment to only "Added a quickstart link from the Plaud source card").
3. Link placement vs. #17882
#17882 asks for "a link from the Integrations Plaud card". The diff adds it to the Knowledge → Sources "🎙️ Plaud voice notes" <details> (knowledge.js:1981), not to the Integrations modal card rendered by kbRenderIntegrationsModal (knowledge.js:2389, Plaud line at kbPlaudAuthLine, :2567). The changelog wording ("Plaud knowledge source setup") matches the diff, not the issue. Minor; consider also emitting the link next to kbPlaudAuthLine(c.name) at :2436.
— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Conclusion: this is a strict subset of #17885 and documents behaviour that does not exist on What I verified (read both branches, not just the diffs):
The body acknowledges this ("merge #17885 first… will need reconciliation"), so this isn't a mismatch between claim and diff — it's a sequencing/duplication call. If #17885 lands first, this PR reduces to the Linked issue #17882 is labelled I have not closed anything. |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
There was a problem hiding this comment.
Summary: this PR is a strict subset of #17885, and on its own it documents a feature v5 does not have. I'd recommend holding it (or closing it in favour of #17885) rather than landing it first — a maintainer should decide which; I have not closed anything.
What I verified
src/docs/inbox-voice-sources.mdhere (headb2730bf) is byte-identical to the same file in #17885 (headf5620c2):diffof the two is empty, 94 lines each. #17885 also carries the samedocumentation-map.mdentry, aknowledge.jschange to the Plaud card, and its ownchangelog.d/added-inbox-voice-sources.md. So once #17885 merges, everything in this PR except the one-line blob link atknowledge.js:1981and the second changelog fragment is a no-op, and the second fragment plus the differingknowledge.jshunk will need manual reconciliation (the PR body already acknowledges this).- On
v5today there is noapi/inboxanywhere in the repository (code search returns 0 hits), andsrc/docs/api-reference/knowledge.mdatv5has noinboxorauth/completerows. Yetinbox-voice-sources.md:90-94tells the reader "See api-reference/knowledge.md forGET /api/inbox,POST /api/inbox/route, …" — that section points at routes the referenced page does not list, and:40-58documents aninbox:config block andPOST /api/inbox/settingsthat nothing onv5reads. If this lands before #17885, the docs are wrong for every reader until the implementation catches up. - #17882 asks for exactly this page plus the two links, so intent matches the issue; the issue is just already covered by #17885 (and is labelled
stage/040-covered-by-pr).
Suggested path: let #17885 (currently changes_requested) land with the page, then rebase this to only the delta — the Plaud-card quickstart link at knowledge.js:1981, if #17885's card rework still wants it — and drop the duplicate page and fragment. Alternatively close this and move that single link into #17885.
Not a finding: test (rest 3/4) shows FAILURE on this head; I could not retrieve the job log, so I have not attributed it to this change.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
kubestellar-prow
Bot
added
size/XL
Summary
v5after ✨ Inbox: voice recorders as first-class input sources (Plaud → spek RFC / dibs / knowledge) #17885 merges.Closes #17882
Verification
go generate ./pkg/dashboard/webstatic/— hive: backend=omp model=openai-codex/gpt-6.1-terra