[pull] midnight from simulationcraft:midnight#634
Merged
Conversation
`init_actor_e` enum lays out the large step categories ``` register_actor_initializer( <priority>, <callback>, <optional name> ) register_actor_initializer( <base name>, <offset>, <callback>, <optional name> ) ``` * Priority: Can be an `init_actor_e` enum or any integer value * Base name, Offset: Alternatively, you can provide a name as the base initializer to apply the offset to for priority * Callback: Can be a functor `std::function<void( player_t* )>` or a pointer to a `player_t` member function * Optional name: Used to resolve priority clashes and identify base for offset, optional ----- * [Sim] use priority-sorted list of initializers for init_actor() * add optional name to initializer entry * register with an offset from another entry * rename player_t::init_stats to player_t::init_stat_data * move raid events related actor initialization code into the raid event * use index loop for running initializers * move emerald_coachs_whistle_ally_ilvl code to unique_gear_dragonflight * move external soleahs_secret_technique code to unique_gear_shadowlands * move potion bomb of power code to unique_gear_thewarwithin * move rallying cry code to sc_warrior * move power infusion code to sc_priest * sort initializer by priority then name * fix typo [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )