keep per-token events out of saved trajectory#295
Open
RyanRana wants to merge 1 commit into
Open
Conversation
Author
|
agent/core/session.py is the fix, the new file is just the test i used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using ML Intern, and then on my own observability tools, I noticed that when there were lots of turns and streamed outputs, the pauses per turn were getting longer and longer. I checked, and it was the trajectory save that was increasing and not the snapshot. Then I built a small test and noticed that it was the assistant chunk in log events that streams tokens and gets fully reserialized after, so all I did stop persisting per-token assistant_chunk events (they're still streamed live, and the real text lives in context_manager.items)