Repository navigation
refactor: trim published package + clearer OTA API/docs (#18 feedback) - #21
Merged
Merged
Conversation
Acts on maintainer feedback in #18. Slimmer tarball: - Ship only runtime scripts via an explicit files allowlist (cli, cli-utils, postinstall, postinstall-lib, bun-postinstall, nsc-utils). Dev/test/ maintainer scripts moved to scripts/dev/ and no longer published. - Add __tests__/pack-contents.test.js to guard against re-bloat. - Remove the monorepo-setup CLI command + monorepo-setup.js/monorepo-utils.js and the pnpm-monorepo fixture. Monorepo/pnpm support is unchanged (it lives in the postinstall safety logic); README documents a resolved-path Gradle snippet. Clearer OTA: - Add applySignedPinBundle(bundle, options) — the verify-and-apply half of updatePinsFromUrl — for callers who fetch the bundle themselves. - Rewrite the README OTA section: signed-bundle format, OtaError code table, the applySignedPinBundle / verifyOtaBundle+setSSLConfig lower-level paths, and a clarification that isExpired/expirationDate (config fail-open) is unrelated to OTA bundle freshness (expiresAt/maxAgeMs). No dependency or nitro-spec changes. 159 tests pass; tsc + eslint clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdDmMzSuVbNXeQcUQNYzk9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acts on the maintainer feedback in #18 ("most files are not needed, especially monorepo setup files" + "no proper docs on how to pair
isExpiredwithupdatePinsFromUrl").1. Slimmer published package
filesnow uses an explicit allowlist of runtime scripts (cli,cli-utils,postinstall,postinstall-lib,bun-postinstall,nsc-utils). Dev/test/maintainer scripts moved toscripts/dev/and are no longer published.rebuild-and-test.js,run-feature-tests.js,test-bun.js,deprecate-v1.shandbuild.shno longer ship.__tests__/pack-contents.test.jsasserts the tarball ships only runtime scripts and never dev tooling / fixtures — guards against re-bloat.monorepo-setupCLI command +monorepo-setup.js/monorepo-utils.js(13.6 kB) and thepnpm-monorepofixture. Monorepo/pnpm support is unchanged — the actual fix lives in the postinstall safety logic; the README now documents a resolved-path Gradle snippet instead of a bespoke command.2. Clearer OTA
applySignedPinBundle(bundle, { publicKey })— the verify-and-apply half ofupdatePinsFromUrl, for callers who fetch the signed bundle themselves (custom networking/caching, push-delivered bundles).updatePinsFromUrlnow = fetch →applySignedPinBundle.OtaErrorcode table, theapplySignedPinBundle/verifyOtaBundle+setSSLConfiglower-level paths (exactly the seam the reporter rebuilt by hand), and a callout clarifyingisExpired/expirationDate(config fail-open) is unrelated to OTA bundle freshness (expiresAt/maxAgeMs) — the specific confusion in the issue.Verification
159 tests pass(including the new pack-contents guard),tsc --noEmitclean,eslintclean on changed sources.nitrogen/spec changes, soyarn install --immutableandyarn specsstay green.Note: dropping the unused
postinstallruntime dependency was intentionally deferred — it needs ayarn.lockregen that isn't possible in this environment.🤖 Generated with Claude Code
https://claude.ai/code/session_01LdDmMzSuVbNXeQcUQNYzk9
Generated by Claude Code