fix: copy current session share URL

[AjTheSpidey]

Fixes #2313.

Found the share button could copy an older URL if the side panel rendered before the session params finished landing in the address bar.

Changed it so the button reads window.location.href when you click it, not during render. I also kept the success/error toast behavior, blocked duplicate clicks while the copy is running, and added tests around the fresh URL + retry cases.

Checked locally:

• yarn workspace @hyperdx/app jest src/tests/SessionSidePanel.test.tsx --runInBand
• yarn prettier --check packages/app/src/SessionSidePanel.tsx packages/app/src/tests/SessionSidePanel.test.tsx
• yarn exec eslint --flag v10_config_lookup_from_file --quiet packages/app/src/SessionSidePanel.tsx packages/app/src/tests/SessionSidePanel.test.tsx
• yarn workspace @hyperdx/app exec tsc --noEmit --pretty false

[vercel]

@AjTheSpidey is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9cad879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Deep Review

✅ No critical issues found. The change moves window.location.href capture from render time to click time, adds a synchronous ref guard for duplicate clicks, tracks mount state for post-await toast suppression, and ships a new test file covering URL freshness, error/rejection paths, duplicate-click coalescing, unmount, and StrictMode.

🟡 P2 — recommended

• packages/app/src/__tests__/SessionSidePanel.test.tsx:194 — no assertion exercises the loading={isSharingSession} prop wired to the Share button, so a regression that hardcodes the prop or skips flipping setIsSharingSession would not be caught even though the duplicate-click ref guard still passes its test.
  • Fix: during the in-flight window of the duplicate-click test, assert screen.getByRole('button', { name: /share session/i }) carries data-loading="true" (or the Mantine spinner is present), and re-assert it clears after finishCopy(true) resolves.

🔵 P3 nitpicks (3)

• packages/app/src/__tests__/SessionSidePanel.test.tsx:247 — await new Promise(resolve => setTimeout(resolve, 0)) after finishCopy(true) flushes a single task tick and will silently false-pass if any future await is added between copy resolution and notifications.show.
  • Fix: drain microtasks via repeated await Promise.resolve() ticks, or replace the manual flush with await waitFor(() => expect(notificationsShowSpy).not.toHaveBeenCalled()) after a small bounded delay.
• packages/app/src/__tests__/SessionSidePanel.test.tsx:137 — URL assertions hard-code http://localhost/sessions?..., coupling the file to jsdom's default origin; a Jest config change to testEnvironmentOptions.url would break every URL assertion even though production behavior is correct.
  • Fix: build expected URLs from ${window.location.origin}/sessions?..., or assert with expect.stringContaining('sid=session-1&sfrom=10&sto=20') for the path-and-query portion only.
• packages/app/src/__tests__/SessionSidePanel.test.tsx:177 — the rejection-path test verifies the red toast fires but never dispatches a follow-up click, so the catch-branch finally { isSharingSessionRef.current = false } reset is never exercised end-to-end (only the success-branch reset is).
  • Fix: after the rejection-path notification assertion, dispatch a second click and assert copyTextToClipboardMock is called a second time.

---

Reviewers (9): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, reliability, agent-native, learnings-researcher.

Testing gaps: loading-state UI prop transition is not pinned by any assertion; the duplicate-click guard reset on the rejection branch is only indirectly covered.

[karl-power]

Thanks for the contribution! I have a few suggestions to simplify the fix.

[karl-power]

I don't think we need this ref, I'm not sure what it's guarding against? The state update and call to notifications are ok without it

[karl-power]

copyTextToClipboard already wraps both the navigator.clipboard.writeText path and the execCommand fallback in their own try/catch, so I don't think this is needed here.

[karl-power]

This can be simplified to:

const handleShareSession = useCallback(async () => {
  if (isSharingSessionRef.current) return;
  isSharingSessionRef.current = true;
  setIsSharingSession(true);

  const copied = await copyTextToClipboard(window.location.href);

  isSharingSessionRef.current = false;
  setIsSharingSession(false);
  notifications.show({
    color: copied ? 'green' : 'red',
    message: copied ? 'Copied link to clipboard' : CLIPBOARD_ERROR_MESSAGE,
  });
}, []);

[pulpdrew]

I believe this is fixed with the (slightly) earlier PR #2318