Skip to content

Use PageHeader title on list pages#2345

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
page-migrate-lists
May 28, 2026
Merged

Use PageHeader title on list pages#2345
kodiakhq[bot] merged 2 commits into
mainfrom
page-migrate-lists

Conversation

@elizabetdev
Copy link
Copy Markdown
Contributor

Summary

Recreated from #2283 now that the base PageLayout/PageHeader work has landed on main.

Test plan

  • Open Alerts, Dashboards list, and Saved Searches; confirm titles and layout unchanged aside from header implementation

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Latest commit: 63cbb9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 28, 2026 11:18am

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 3
  • Production lines changed: 6
  • Branch: page-migrate-lists
  • Author: elizabetdev

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Deep Review

✅ No critical issues found.

This is a 3-line refactor that swaps children-based PageHeader usage for the typed title prop on three list pages, matching the API the project-standards reviewer confirmed is the prescribed pattern in agent_docs/page_layout.md (which names Alerts, Dashboards, and Saved Searches explicitly). The new render path wraps each title in <h1 class={styles.title}> whose CSS resets font properties to inherit, so the visible header is layout-equivalent and accessibility improves with a real heading element. The @hyperdx/app: patch changeset scope and tier are appropriate for a no-behavior-change refactor.


Reviewers (5): correctness, testing, maintainability, project-standards, kieran-typescript.

Testing gaps:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

E2E Test Results

All tests passed • 193 passed • 3 skipped • 1124s

Status Count
✅ Passed 193
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Aligns Alerts, Dashboards, and Saved Searches with the shared header API.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kodiakhq kodiakhq Bot merged commit 0e8a5b3 into main May 28, 2026
18 checks passed
@kodiakhq kodiakhq Bot deleted the page-migrate-lists branch May 28, 2026 11:23
elizabetdev added a commit that referenced this pull request May 28, 2026
Main now contains two additional structured-slot users:
- AlertsPage / DashboardsListPage / SavedSearchesListPage (#2345) now
  use `<PageHeader title="..." />` instead of the children form.
- DBServiceMapPage (#2346) uses `<PageLayout leading actions />`.

Update PageLayout / PageHeader JSDoc to cite the three concrete slot
shapes (title-only, leading+actions, breadcrumbs+leading+actions) with
the now-canonical examples, so future page migrations have an obvious
reference for which form to pick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants