Skip to content

Migrate ClickHouse dashboard to PageLayout#2348

Merged
elizabetdev merged 3 commits into
mainfrom
page-migrate-clickhouse
May 29, 2026
Merged

Migrate ClickHouse dashboard to PageLayout#2348
elizabetdev merged 3 commits into
mainfrom
page-migrate-clickhouse

Conversation

@elizabetdev
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev commented May 27, 2026

Summary

  • Wraps the ClickHouse dashboard in PageLayout with breadcrumbs and sticky header controls (connection, time range, refresh).
  • Preserves the browser tab title (ClickHouse Dashboard – {brandName}) that was added in feat: Minor dashboard improvements #2302.

Recreated from #2286 now that the base PageLayout/PageHeader work has landed on main. The cherry-pick conflicted with #2302 (which added the <Head> tab title); resolution keeps the new tab title inside the PageLayout content.

Test plan

  • ClickHouse dashboard loads; tabs and charts work
  • Time range and connection selector behave as before
  • Browser tab title still reads "ClickHouse Dashboard – "

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c7d0c4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 29, 2026 12:02pm
hyperdx-storybook Ready Ready Preview, Comment May 29, 2026 12:02pm

Request Review

@github-actions github-actions Bot added the review/tier-3 Standard — full human review required label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026 •
edited
Loading

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

  • Diff size: 529 production lines changed (Tier 2 max: < 250)

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats
  • Production files changed: 1
  • Production lines changed: 529
  • Branch: page-migrate-clickhouse
  • Author: elizabetdev

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026 •
edited
Loading

Deep Review

✅ No critical issues found.

Pure layout migration that mirrors the just-merged Kubernetes dashboard refactor (#2347) and matches the spec in agent_docs/page_layout.md. The forwarded data-testid keeps the e2e selector getByTestId('clickhouse-dashboard-page') resolving (the page object's .locator('div').filter({ hasText: 'Query Latency' }) chain still finds the heatmap container as a descendant of PageLayout's root). padded maps to the same var(--mantine-spacing-sm) token the old <Box p="sm"> used. Box is no longer referenced after the refactor, and no new // @ts-ignore was introduced — the two existing ones are preserved. <Head> placement inside content matches the existing convention in KubernetesDashboardPage.tsx and DBServiceMapPage.tsx.

Reviewers (7): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher, kieran-typescript

Testing gaps:

  • packages/app/tests/e2e/page-objects/ClickHouseDashboardPage.ts does not cover the new sticky-header chrome introduced by this diff (breadcrumb trail, refresh aria-label="Refresh dashboard"); existing heatmap-only smoke test still passes but the new visible surface lacks regression coverage.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 191 passed • 3 skipped • 1306s

Status Count
✅ Passed 191
❌ Failed 0
⚠️ Flaky 4
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@elizabetdev @cursoragent
Migrate ClickHouse dashboard to PageLayout.
1d24d98 
Sticky header includes breadcrumbs, connection selector, and refresh
controls without a duplicate page title.

Co-authored-by: Cursor <cursoragent@cursor.com>
@elizabetdev elizabetdev force-pushed the page-migrate-clickhouse branch from cfc76ea to 1d24d98 Compare May 27, 2026 17:16
@elizabetdev elizabetdev merged commit 800081c into main May 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fleon fleon fleon approved these changes

Assignees

No one assigned

Labels

review/tier-3 Standard — full human review required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elizabetdev @fleon