Repository navigation
Collapse maxProperties and minProperties error messages - #145
Merged
jdesrosiers merged 1 commit intoJan 28, 2026
Merged
jdesrosiers merged 1 commit into
jdesrosiers merged 1 commit into
Conversation
jdesrosiers
requested changes
Jan 27, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Great job! Just one tweak I'd like to see (see inline comment).
ShivaGupta-14
force-pushed
the
137-collapse-max-min-properties-message
branch
from
January 27, 2026 06:59
19f5eb0 to
cc22b64
Compare
jdesrosiers
approved these changes
Jan 28, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When multiple maxProperties or minProperties constraints fail (e.g., via allOf), produce a single message with the most restrictive constraint instead of multiple redundant messages.
maxProperties: use minimum value (tightest upper bound)
minProperties: use maximum value (tightest lower bound)
Fixes: Combine messages for minProperties/maxProperties #137
Checklist
Additional Notes
Screenshot