Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 88.80% 88.84% +0.03%
==========================================
Files 113 112 -1
Lines 13135 13113 -22
Branches 2425 2421 -4
==========================================
- Hits 11665 11650 -15
+ Misses 923 920 -3
+ Partials 547 543 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes RosettaSciIO’s vendored copy of skimage.exposure.rescale_intensity now that the project targets scikit-image>=0.20, and updates the Blockfile writer to use the upstream scikit-image implementation directly. This reduces maintenance burden and eliminates version-conditional behavior that was only needed for older scikit-image releases.
Changes:
- Removed the vendored
rescale_intensityimplementation (rsciio/utils/_skimage_exposure.py). - Updated Blockfile writing code to import/use
skimage.exposure.rescale_intensitydirectly when intensity scaling is requested. - Added a Towncrier changelog fragment documenting the maintenance change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| upcoming_changes/527.maintenance.rst | Adds a maintenance changelog entry for the removal of vendored scikit-image code. |
| rsciio/utils/_skimage_exposure.py | Deletes the vendored rescale_intensity implementation. |
| rsciio/blockfile/_api.py | Switches Blockfile intensity scaling to use skimage.exposure.rescale_intensity directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
355958d to
d6435e0
Compare
…nd avoid failure with saving lasy signal
d6435e0 to
890740a
Compare
Fix for hyperspy/hyperspy-extensions-list#111.
It doesn't seem to be necessary anymore - from looking at the history, it was introduced during the split and the only difference is around support of scikit-image for version <0.20. Currently, the requirement is scikit-image>=0.20.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:rosettasciiobuild of this PR (link in github checks)