Repository navigation
fix: allow sheet closing text in SVS recipes - #377
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authors who put a literal
</sheet>in a Text Template prompt getSVS_TRAILINGinstead of rendered text. A prompt showing someone how to write SVS markup is one case.The SVS parser found the first
</sheet>in the source, even when it was inside a quoted recipe value. It now uses the final closing tag. One regression test round-trips the value through the SVS formatter. Another parses the recipe into a Text Template and renders the prompt. Both failed with the original parser and pass with the fix.Text after the actual closing tag is still rejected. Malformed files with a duplicate closing tag remain rejected, though their error changes from
SVS_TRAILINGtoSVS_RULE.Checks run:
pnpm checkpnpm test(1,105 passed, 21 skipped, 0 failed)