Repository navigation
fix(report): leave junk out of ai-queries and check only askable questions - #138
Merged
Merged
Conversation
…tions Split letters, broken encoding and pasted tool or agent text are left out of ai-queries and counted. Each question gets an askable flag, and ai_answers spends calls only on askable questions. Amp-Thread-ID: https://ampcode.com/threads/T-01a15a6b-b6b3-75de-9a30-6cec07eb3164 Co-authored-by: Ian Nuttall <6681919+iannuttall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a real site, 9 of the 10 questions that ai_answers paid to check were junk: letters split by spaces, text broken by a wrong encoding, a stray "p" left from an HTML tag, and pasted agent or tool output.
leftOut.askableflag: a chat or long query that opens with a question word or a request, or ends with a question mark. Statements and pasted field lists are not askable.One regression test uses made-up queries in the same shapes. On the same site, all 10 questions picked are now real questions.