Return drained events before blocking in EiConvertEventIterator::next#31
Open
jonas73x wants to merge 1 commit into
Open
Return drained events before blocking in EiConvertEventIterator::next#31jonas73x wants to merge 1 commit into
jonas73x wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25, which drains buffered requests before poll_readable but doesn't return the events the drain just queued.
This deadlocks a sender: the server sends the seat, then goes silent waiting for the client to bind capabilities. The queued SeatAdded is never returned, so poll_readable blocks forever and the client hangs before it can bind. Receivers are unaffected (input keeps the socket readable).
Fix: return any queued event after the drain loop, before blocking.