Fix EVA refuel for custom inventory propellants - #416
Open
sdy623 wants to merge 1 commit into
Open
Conversation
sdy623
marked this pull request as ready for review
August 30, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415.
Summary
EVA Propellantwhile supporting configurations such as Kerbalism / Realism Overhaul usingNitrogen.Cause
RefillEvaPackalready obtains the active runtimePartResourcefromKerbalEVA.propellantResource, but the subsequent KSP 1.11+ inventory lookup ignores it and filters snapshots usingStockResourceNames.EvaPropellant.When the stored
evaJetpacksnapshot containsNitrogen, the query returns no resources and KIS reports:Change
Use the resource name from the active runtime propellant:
This is intentionally limited to the target stock-inventory lookup. It does not change canister supply-resource handling or Kerbalism's boarding behavior.
Validation
master.NitrogenunderModuleInventoryPart / STOREDPART (evaJetpack) / RESOURCE, rather than as a matching resource directly onkerbalEVA.masterand changes one line in one file.Related issue
#360 made the canister's source resource configurable. This change covers the remaining hard-coded target-resource lookup in the stock-inventory path.