transpile: Bypass platform-specific internal typedefs for portable types#1850
Merged
Conversation
Rua
force-pushed
the
portable-types-typedefs
branch
4 times, most recently
from
e188510 to
529e6a3
Compare
Rua
force-pushed
the
portable-types-typedefs
branch
2 times, most recently
from
afd6490 to
dc89ce3
Compare
fw-immunant
approved these changes
Jun 16, 2026
fw-immunant
left a comment
fw-immunant
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! It looks good, but it would be nice to restore some documentation for the top-level fn bypass_typedefs. Do you want to add docs or should I do so after merging?
Rua
force-pushed
the
portable-types-typedefs
branch
from
dc89ce3 to
ef3498e
Compare
Contributor
Author
|
@fw-immunant I've added docs for it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates a bunch of differences between platforms, so that they produce the same output. It does seem like the order of the typedefs can still differ, so they sometimes still need separate snapshot tests. Maybe a solution can be found for that in the future too.