Skip to content

fix: Names not defined in list comprehension in the IPython shell #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
caorantaoyao wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Names not defined in list comprehension in the IPython shell #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pudb/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,27 +167,31 @@ def run_ipython_shell_v10(globals, locals):
else:
banner = ""

# avoid IPython's namespace litter
ns = locals.copy()
# Comprehensions execute in the global namespace, so it must also contain
# the frame's locals.
ns = SetPropagatingDict([locals, globals], locals)

from IPython.Shell import IPShell
IPShell(argv=[], user_ns=ns, user_global_ns=globals) \
IPShell(argv=[], user_ns=ns, user_global_ns=ns) \
.mainloop(banner=banner)


def _update_ipython_ns(shell, globals, locals):
"""Update the IPython 0.11 namespace at every visit"""

shell.user_ns = locals.copy()
# Code inside comprehensions and generator expressions resolves names in
# the global namespace. Use one combined namespace so frame locals remain
# visible there as well.
shell.user_ns = SetPropagatingDict([locals, globals], locals)

try:
shell.user_global_ns = globals
shell.user_global_ns = shell.user_ns
except AttributeError:
class DummyMod:
"""A dummy module used for IPython's interactive namespace."""

user_module = DummyMod()
user_module.__dict__ = globals
user_module.__dict__ = shell.user_ns
shell.user_module = user_module

shell.init_history()
Expand Down