Skip to content

docs(planner): align the limit() doc bullet list with the signature - #27649

Open
simpleqt wants to merge 1 commit into
influxdata:mainfrom
simpleqt:sq919/limit-doc
Open

simpleqt wants to merge 1 commit into
influxdata:mainfrom
simpleqt:sq919/limit-doc

Conversation

@simpleqt

Copy link
Copy Markdown

The ## Arguments list for LogicalPlanBuilder::limit (core/iox_query_influxql/src/plan/planner.rs) documents a time_sort_expr parameter that no longer exists — the signature is now:

fn limit(&self, input, offset, limit, fill_clause: &FillClause, sort_exprs: Vec<SortExpr>, group_by_tag_set, projection_tag_set)

The doc bullet is renamed to sort_exprs and the previously undocumented fill_clause parameter is added.

Docs-only change.

Signed CLA

The Arguments list documented 'time_sort_expr', a parameter that was
renamed to 'sort_exprs' (and is now a Vec<SortExpr>), and omitted the
'fill_clause' parameter entirely.
Copilot AI lite review requested due to automatic review settings September 19, 2026 08:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants