8.29.5 - #924
Merged
Merged
8.29.5#924
Conversation
…st convention Introduce `_iblrig_tasks_trainingChoiceWorld_c0_CW` protocol that reproduces TrainingChoiceWorld behavior from IBLRIG versions 8.10.0-8.23.3. Zero-contrast trials always place stimulus on the left (clockwise turn rewarded) instead of random side assignment. Enables consistency with subjects trained under legacy convention.
5 tasks
…ontrast convention Introduce `_iblrig_tasks_trainingPhaseChoiceWorld_c0_CW` protocol that reproduces TrainingPhaseChoiceWorld behavior from IBLRIG versions 8.10.0-8.23.3. Zero-contrast trials always place stimulus on the left (clockwise turn rewarded) instead of random side assignment. Enables consistency with subjects trained under legacy convention.
Extract stimulus position assignment logic into `_map_signed_contrast_to_position()` method across base and C0_CW task classes. Simplifies `next_trial()` implementation and improves code reusability. Update docstring references accordingly.
k1o0
requested changes
Jun 17, 2026
|
coverage: 50.252% (+0.1%) from 50.121% — fix/trainingCW_old_logic into iblrigv8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.