Repository navigation
🚸 Better diagnostic for extending a missing export - #988
Merged
Merged
Conversation
elbeno
requested review from
SANTOSHKUMARLAXMINARAYANRAI,
lukevalenty,
mjcaisse-intel and
siauthun
October 21, 2026 01:52
elbeno
force-pushed
the
extend-fail-test
branch
from
October 21, 2026 02:15
a4460ae to
4a65af2
Compare
Problem: - When extending a service by type, the type might have a name; this isn't used when issuing a diagnostic for trying to extend an unexported service. Solution: - If the extension type has a name, use it.
elbeno
force-pushed
the
extend-fail-test
branch
from
October 21, 2026 02:18
4a65af2 to
cc2d9e0
Compare
lukevalenty
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution: